From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEed9-00075A-87 for qemu-devel@nongnu.org; Tue, 05 Aug 2014 09:18:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEed4-0005Zs-Bb for qemu-devel@nongnu.org; Tue, 05 Aug 2014 09:18:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEed4-0005Zl-3n for qemu-devel@nongnu.org; Tue, 05 Aug 2014 09:18:14 -0400 Message-ID: <53E0D992.70904@redhat.com> Date: Tue, 05 Aug 2014 07:18:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406936961-20356-1-git-send-email-mreitz@redhat.com> <1406936961-20356-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1406936961-20356-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cdEj0L7IfgGaG74l2il0DuTlR2d1qIexQ" Subject: Re: [Qemu-devel] [PATCH v2 5/7] block/qcow2: Make get_refcount() global List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cdEj0L7IfgGaG74l2il0DuTlR2d1qIexQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/01/2014 05:49 PM, Max Reitz wrote: > Reading the refcount of a cluster is an operation which can be useful i= n > all of the qcow2 code, so make that function globally available. >=20 > While touching this function, amend the comment describing the "addend"= > parameter: It is (no longer, if it ever was) necessary to have it set t= o > -1 or 1; any value is fine. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 26 +++++++++++++------------- > block/qcow2.h | 2 ++ > 2 files changed, 15 insertions(+), 13 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cdEj0L7IfgGaG74l2il0DuTlR2d1qIexQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT4NmSAAoJEKeha0olJ0Nq53cH/iOASfElfRkb+rG06T73tNH0 i36OVolgFvg2oYfEM1YNbfJSqMfkkK5dtm0sCraxeQoHnSwEC9gpyVqhat0XqPCx KvzXh4IvGuUhc81oWlSF7GvkLsPmnwwKAHDIm32WPiQGUVUgkB7hw9GyF4OiRVyL +iHoQg9aTzXkasa/Q9V7mCvpT7s268nmMHzAFp82tyd4gN4M2yvwXBbuuh7kRmWE 1r0HyX48CEndfJ54Fctbt/2hiujI+qt/xD7fZwLTaquCA3tiO/iyfZ8HUfmGAwlL H1mwY/+p0twvcFyongY+bKZS5NjVlqz9ayTiQ3DY5RVZGffea4qWyhNt48PwL+Y= =deLs -----END PGP SIGNATURE----- --cdEj0L7IfgGaG74l2il0DuTlR2d1qIexQ--