From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEgM2-0000Sy-Fv for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:08:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEgLr-0004SW-Pk for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:08:46 -0400 Received: from mx.beyond.pl ([92.43.117.49]:55420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEgLr-0004SR-IJ for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:08:35 -0400 Message-ID: <53E0F36E.4030700@beyond.pl> Date: Tue, 05 Aug 2014 17:08:30 +0200 From: =?UTF-8?B?TWFyY2luIEdpYnXFgmE=?= MIME-Version: 1.0 References: <1405435466-20801-1-git-send-email-stefanha@redhat.com> <53C54602.6050003@redhat.com> In-Reply-To: <53C54602.6050003@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Christian Borntraeger On 15.07.2014 17:17, Paolo Bonzini wrote: > Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: >> v2: >> * Leave BH scheduled so that the code can be simplified [Paolo] >> >> These patches convert thread-pool.c from EventNotifier to QEMUBH. >> They then >> solve the deadlock when nested aio_poll() calls are made. >> >> Please speak out whether you want this in QEMU 2.1 or not. I'm not >> aware of >> the nested aio_poll() deadlock ever having been reported, so maybe we >> can defer >> to QEMU 2.2. > > It was reported as a hang in block_commit. Marcin, can you please test > these patches? Sorry for late answer - yes, it seems to fix block_commit hang when using thread-pool. -- mg