From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [PATCH] libxl: support domainReset
Date: Tue, 05 Aug 2014 09:10:39 -0600
Message-ID: <53E0F3EF.3020101@suse.com>
References: <1407204567-4131-1-git-send-email-jfehlig@suse.com>	<1407227582.2120.3.camel@kazak.uk.xensource.com>	<20140805084151.GA27835@aepfle.de>	<1407228326.2120.15.camel@kazak.uk.xensource.com>	<20140805085520.GA30208@aepfle.de>	<1407229149.2120.26.camel@kazak.uk.xensource.com>	<53E0E4DE.30506@suse.com>
	<1407247933.2120.37.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1407247933.2120.37.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: libvir-list@redhat.com, Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Ian Campbell wrote:
> On Tue, 2014-08-05 at 08:06 -0600, Jim Fehlig wrote:
>   
>> Ian Campbell wrote:
>>     
>>> On Tue, 2014-08-05 at 10:55 +0200, Olaf Hering wrote:
>>>   
>>>       
>>>> The original report was that 'Reset' does not work from GUI, like
>>>> virt-manager or virsh. I think the expected outcome is like pushing the
>>>> reset button on a physical board. Xen doesnt do it that way, no idea
>>>> about others.
>>>>     
>>>>         
>>> Sounds like you want libxl_domain_reboot then, perhaps with a fallback
>>> on ERROR_NOPARAVIRT for an HVM guest to sending a trigger.
>>>   
>>>       
>> Hrm, I don't think that's right .  It should be a hard reset
>>
>> http://libvirt.org/html/libvirt-libvirt.html#virDomainReset
>>
>> destroy/start seems the correct way to implement this.
>>     
>
> Yes, given that requirement it is. Sorry for the noise.
>
> Would some sort of hard reset API be useful in libxl?
>   

Sure.  I think having an API that emulates a power reset button would be
a nice addition to libxl's domain operations.  The destroy/start
approach incurs a small bit of overhead, which would be avoided with
such an API.  Clients (perhaps incorrectly) implementing their own
notion of reset  would also be avoided.

In the absence of libxl_domain_reset(), do folks think the destroy/start
approach is acceptable?  As Olaf mentioned, it allows "Force Reset" to
work via virt-manager.

Regards,
Jim