From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH] pass-through: fix unbinding of MSI interrupts Date: Tue, 05 Aug 2014 11:53:03 -0400 Message-ID: <53E0FDDF.5090304@oracle.com> References: <53E0F42C02000078000297BF@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XEh30-000101-BV for xen-devel@lists.xenproject.org; Tue, 05 Aug 2014 15:53:10 +0000 In-Reply-To: <53E0F42C02000078000297BF@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Sander Eikelenboom List-Id: xen-devel@lists.xenproject.org On 08/05/2014 09:11 AM, Jan Beulich wrote: > Commit 568da4f8 ("pt-irq fixes and improvements") went a little too far > in its cleaning up of pt_irq_destroy_bind(): While neither of the two > lists need any maintenance, the actual unbinding still needs to be > done. Fix this and at once > - move all variables applying only to the PCI/MSI-translate cases into > scopes where they can't be used in error, > - limit the final (optional) log message to the cases it actually > applies and enhance it to make clear how much cleaning up was > actually done. > > Reported-by: Sander Eikelenboom > Signed-off-by: Jan Beulich Tested-by: Boris Ostrovsky