From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jindal, Sonika" <sonika.jindal@intel.com>
Subject: Re: [PATCH 1/6] drm: Renaming DP training
 vswing/pre-emph defines
Date: Wed, 06 Aug 2014 11:01:52 +0530
Message-ID: <53E1BDC8.4030206@intel.com>
References: <1407236902-11326-1-git-send-email-sonika.jindal@intel.com>	<1407236902-11326-2-git-send-email-sonika.jindal@intel.com>	<20140805111535.GH8727@phenom.ffwll.local>	<53E0C124.7080907@intel.com>
 <CAKMK7uGMQk-b1WkAWvH+MNOEPsAnrTZKAzws2O9apx2dxrLhuQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <CAKMK7uGMQk-b1WkAWvH+MNOEPsAnrTZKAzws2O9apx2dxrLhuQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org



On 8/5/2014 6:00 PM, Daniel Vetter wrote:
> On Tue, Aug 5, 2014 at 1:33 PM, Jindal, Sonika <sonika.jindal@intel.com> wrote:
>>
>>
>> On 8/5/2014 4:45 PM, Daniel Vetter wrote:
>>>
>>> On Tue, Aug 05, 2014 at 04:38:17PM +0530, sonika.jindal@intel.com wrote:
>>>>
>>>> From: Sonika Jindal <sonika.jindal@intel.com>
>>>>
>>>> Renaming defines to have levels instead of nominal values.
>>>>
>>>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>>>
>>>
>>> You can't split up patches like this since this will break compilation.
>>> For larger stuff (and imo this is right above the cutoff) you first need
>>> to add the new functions/defines, then convert everyone over. And only
>>> when all the drivers are converted can we apply the patch to remove the
>>> old functions/defines.
>>> -Daniel
>>>
>> Got your concern. So, I will repost the first patch keeping both the defines
>> and an additional last patch for removing the extra defines.
>
> Yeah. Btw for the actual replacement I highly recommend to do it with
> a semantic patch and cocci. There's unfortunately not a hole lot of
> good documentation around, but we recently started and it helps a lot
> with regenerating patches (e.g. for newly merged drm drivers) and
> avoiding mistakes for manual conversions. If we do a cocci patch we
> put it into the commit message, grep for @@.
> -Daniel
>
I need to find out about cocci. Can we go ahead with this patch series only?
-Sonika