From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Wed, 06 Aug 2014 07:09:11 +0000 Subject: Re: [PATCH] arch/sparc/math-emu/math_32.c: drop stray break operator Message-Id: <53E1D497.3080309@bfs.de> List-Id: References: <1407185261-1799-1-git-send-email-andrey.krieger.utkin@gmail.com> <53E083B8.4090008@bfs.de> <20140805.124939.1701979639778778101.davem@davemloft.net> In-Reply-To: <20140805.124939.1701979639778778101.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: David Miller Cc: andrey.krieger.utkin@gmail.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org CgpBbSAwNS4wOC4yMDE0IDIxOjQ5LCBzY2hyaWViIERhdmlkIE1pbGxlcjoKPiBGcm9tOiB3YWx0 ZXIgaGFybXMgPHdoYXJtc0BiZnMuZGU+Cj4gRGF0ZTogVHVlLCAwNSBBdWcgMjAxNCAwOToxMTo1 MiArMDIwMAo+IAo+Pgo+Pgo+PiBBbSAwNC4wOC4yMDE0IDIyOjQ3LCBzY2hyaWViIEFuZHJleSBV dGtpbjoKPj4+IFRoaXMgY29tbWl0IGlzIGEgZ3Vlc3N3b3JrLCBidXQgaXQgc2VlbXMgdG8gbWFr ZSBzZW5zZSB0byBkcm9wIHRoaXMKPj4+IGJyZWFrLCBhcyBvdGhlcndpc2UgdGhlIGZvbGxvd2lu ZyBsaW5lIGlzIG5ldmVyIGV4ZWN1dGVkIGFuZCBiZWNvbWVzCj4+PiBkZWFkIGNvZGUuIEFuZCB0 aGF0IGZvbGxvd2luZyBsaW5lIGFjdHVhbGx5IHNhdmVzIHRoZSByZXN1bHQgb2YKPj4+IGxvY2Fs IGNhbGN1bGF0aW9uIGJ5IHRoZSBwb2ludGVyIGdpdmVuIGluIGZ1bmN0aW9uIGFyZ3VtZW50LiBT byB0aGUKPj4+IHByb3Bvc2VkIGNoYW5nZSBtYWtlcyBzZW5zZSBpZiB0aGlzIGNvZGUgaW4gdGhl IHdob2xlIG1ha2VzIHNlbnNlIChidXQgSQo+Pj4gYW0gdW5hYmxlIHRvIGFuYWx5emUgaXQgaW4g dGhlIHdob2xlKS4KPj4+Cj4+PiBCdWd6aWxsYTogaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3Jn L3Nob3dfYnVnLmNnaT9pZIE2NDEKPj4+IFJlcG9ydGVkLWJ5OiBEYXZpZCBCaW5kZXJtYW4gPGRj YjMxNEBob3RtYWlsLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJleSBVdGtpbiA8YW5kcmV5 LmtyaWVnZXIudXRraW5AZ21haWwuY29tPgo+Pj4gLS0tCj4+PiAgYXJjaC9zcGFyYy9tYXRoLWVt dS9tYXRoXzMyLmMgfCAyICstCj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvc3BhcmMvbWF0aC1lbXUvbWF0 aF8zMi5jIGIvYXJjaC9zcGFyYy9tYXRoLWVtdS9tYXRoXzMyLmMKPj4+IGluZGV4IGFhNGQ1NWIu LjVjZThmMmYgMTAwNjQ0Cj4+PiAtLS0gYS9hcmNoL3NwYXJjL21hdGgtZW11L21hdGhfMzIuYwo+ Pj4gKysrIGIvYXJjaC9zcGFyYy9tYXRoLWVtdS9tYXRoXzMyLmMKPj4+IEBAIC00OTksNyArNDk5 LDcgQEAgc3RhdGljIGludCBkb19vbmVfbWF0aGVtdSh1MzIgaW5zbiwgdW5zaWduZWQgbG9uZyAq cGZzciwgdW5zaWduZWQgbG9uZyAqZnJlZ3MpCj4+PiAgCQljYXNlIDA6IGZzciA9ICpwZnNyOwo+ Pj4gIAkJCWlmIChJUiA9IC0xKSBJUiA9IDI7Cj4+PiAgCQkJLyogZmNjIGlzIGFsd2F5cyBmY2Mw ICovCj4+Cj4+IFRoZSBwYXRjaCBsb29rcyBvaywgYnV0IGNhbiBzb21lYm9keSBjb21tZW50IG9u IHRoaXMgY29tbWVudCA/Cj4+IHdoYXQgImZjYyIgPyBzaG91bGQgaXQgYmUgYSBmc3IgPwo+IAo+ IEl0J3MgdGhlIGNvbmRpdGlvbiBjb2RlIGZpZWxkIGluc2lkZSBvZiB0aGUgJWZzciByZWdpc3Rl ci4KPiAKPiBJbiAzMi1iaXQgY2hpcHMgdGhlcmUgaXMgb25seSBvbmUgc2V0IG9mIGNvbmRpdGlv biBjb2Rlcywgd2hlcmVhcwo+IG9uIDY0LWJpdCBjaGlwcyB0aGVyZSBhcmUgNCBzZXRzIHJlZmVy cmVkIHRvIGFzIGZjYzAsIGZjYzEsIGZjYzIsCj4gYW5kIGZjYzMuCj4gCj4gVGhhdCdzIHdoYXQg dGhpcyBjb21tZW50IGlzIHRhbGtpbmcgYWJvdXQuCj4gCnRoeCBmb3IgaW5mbywKCndvdWxkIHlv dSBtaW5kIHRvIGFkZCB5b3VyIGV4cGxhbmF0aW9uID8KSXQgaXMgbXVjaCBtb3IgaGVscGZ1bCB0 aGF0IHRoZSBjb21tZW50IHJpZ2h0IG5vdy4KCnJlLAogd2gKCi0tClRvIHVuc3Vic2NyaWJlIGZy b20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBrZXJuZWwtamFuaXRvcnMi IGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1v cmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWlu Zm8uaHRtbA== From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Wed, 06 Aug 2014 07:09:11 +0000 Subject: Re: [PATCH] arch/sparc/math-emu/math_32.c: drop stray break operator Message-Id: <53E1D497.3080309@bfs.de> List-Id: References: <1407185261-1799-1-git-send-email-andrey.krieger.utkin@gmail.com> <53E083B8.4090008@bfs.de> <20140805.124939.1701979639778778101.davem@davemloft.net> In-Reply-To: <20140805.124939.1701979639778778101.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: David Miller Cc: andrey.krieger.utkin@gmail.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org CgpBbSAwNS4wOC4yMDE0IDIxOjQ5LCBzY2hyaWViIERhdmlkIE1pbGxlcjoKPiBGcm9tOiB3YWx0 ZXIgaGFybXMgPHdoYXJtc0BiZnMuZGU+Cj4gRGF0ZTogVHVlLCAwNSBBdWcgMjAxNCAwOToxMTo1 MiArMDIwMAo+IAo+Pgo+Pgo+PiBBbSAwNC4wOC4yMDE0IDIyOjQ3LCBzY2hyaWViIEFuZHJleSBV dGtpbjoKPj4+IFRoaXMgY29tbWl0IGlzIGEgZ3Vlc3N3b3JrLCBidXQgaXQgc2VlbXMgdG8gbWFr ZSBzZW5zZSB0byBkcm9wIHRoaXMKPj4+IGJyZWFrLCBhcyBvdGhlcndpc2UgdGhlIGZvbGxvd2lu ZyBsaW5lIGlzIG5ldmVyIGV4ZWN1dGVkIGFuZCBiZWNvbWVzCj4+PiBkZWFkIGNvZGUuIEFuZCB0 aGF0IGZvbGxvd2luZyBsaW5lIGFjdHVhbGx5IHNhdmVzIHRoZSByZXN1bHQgb2YKPj4+IGxvY2Fs IGNhbGN1bGF0aW9uIGJ5IHRoZSBwb2ludGVyIGdpdmVuIGluIGZ1bmN0aW9uIGFyZ3VtZW50LiBT byB0aGUKPj4+IHByb3Bvc2VkIGNoYW5nZSBtYWtlcyBzZW5zZSBpZiB0aGlzIGNvZGUgaW4gdGhl IHdob2xlIG1ha2VzIHNlbnNlIChidXQgSQo+Pj4gYW0gdW5hYmxlIHRvIGFuYWx5emUgaXQgaW4g dGhlIHdob2xlKS4KPj4+Cj4+PiBCdWd6aWxsYTogaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3Jn L3Nob3dfYnVnLmNnaT9pZIE2NDEKPj4+IFJlcG9ydGVkLWJ5OiBEYXZpZCBCaW5kZXJtYW4gPGRj YjMxNEBob3RtYWlsLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJleSBVdGtpbiA8YW5kcmV5 LmtyaWVnZXIudXRraW5AZ21haWwuY29tPgo+Pj4gLS0tCj4+PiAgYXJjaC9zcGFyYy9tYXRoLWVt dS9tYXRoXzMyLmMgfCAyICstCj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvc3BhcmMvbWF0aC1lbXUvbWF0 aF8zMi5jIGIvYXJjaC9zcGFyYy9tYXRoLWVtdS9tYXRoXzMyLmMKPj4+IGluZGV4IGFhNGQ1NWIu LjVjZThmMmYgMTAwNjQ0Cj4+PiAtLS0gYS9hcmNoL3NwYXJjL21hdGgtZW11L21hdGhfMzIuYwo+ Pj4gKysrIGIvYXJjaC9zcGFyYy9tYXRoLWVtdS9tYXRoXzMyLmMKPj4+IEBAIC00OTksNyArNDk5 LDcgQEAgc3RhdGljIGludCBkb19vbmVfbWF0aGVtdSh1MzIgaW5zbiwgdW5zaWduZWQgbG9uZyAq cGZzciwgdW5zaWduZWQgbG9uZyAqZnJlZ3MpCj4+PiAgCQljYXNlIDA6IGZzciA9ICpwZnNyOwo+ Pj4gIAkJCWlmIChJUiA9IC0xKSBJUiA9IDI7Cj4+PiAgCQkJLyogZmNjIGlzIGFsd2F5cyBmY2Mw ICovCj4+Cj4+IFRoZSBwYXRjaCBsb29rcyBvaywgYnV0IGNhbiBzb21lYm9keSBjb21tZW50IG9u IHRoaXMgY29tbWVudCA/Cj4+IHdoYXQgImZjYyIgPyBzaG91bGQgaXQgYmUgYSBmc3IgPwo+IAo+ IEl0J3MgdGhlIGNvbmRpdGlvbiBjb2RlIGZpZWxkIGluc2lkZSBvZiB0aGUgJWZzciByZWdpc3Rl ci4KPiAKPiBJbiAzMi1iaXQgY2hpcHMgdGhlcmUgaXMgb25seSBvbmUgc2V0IG9mIGNvbmRpdGlv biBjb2Rlcywgd2hlcmVhcwo+IG9uIDY0LWJpdCBjaGlwcyB0aGVyZSBhcmUgNCBzZXRzIHJlZmVy cmVkIHRvIGFzIGZjYzAsIGZjYzEsIGZjYzIsCj4gYW5kIGZjYzMuCj4gCj4gVGhhdCdzIHdoYXQg dGhpcyBjb21tZW50IGlzIHRhbGtpbmcgYWJvdXQuCj4gCnRoeCBmb3IgaW5mbywKCndvdWxkIHlv dSBtaW5kIHRvIGFkZCB5b3VyIGV4cGxhbmF0aW9uID8KSXQgaXMgbXVjaCBtb3IgaGVscGZ1bCB0 aGF0IHRoZSBjb21tZW50IHJpZ2h0IG5vdy4KCnJlLAogd2gKCi0tClRvIHVuc3Vic2NyaWJlIGZy b20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBzcGFyY2xpbnV4IiBpbgp0 aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1h am9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0 bWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754867AbaHFHJY (ORCPT ); Wed, 6 Aug 2014 03:09:24 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:22078 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753446AbaHFHJU (ORCPT ); Wed, 6 Aug 2014 03:09:20 -0400 Message-ID: <53E1D497.3080309@bfs.de> Date: Wed, 06 Aug 2014 09:09:11 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: David Miller CC: andrey.krieger.utkin@gmail.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] arch/sparc/math-emu/math_32.c: drop stray break operator References: <1407185261-1799-1-git-send-email-andrey.krieger.utkin@gmail.com> <53E083B8.4090008@bfs.de> <20140805.124939.1701979639778778101.davem@davemloft.net> In-Reply-To: <20140805.124939.1701979639778778101.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 05.08.2014 21:49, schrieb David Miller: > From: walter harms > Date: Tue, 05 Aug 2014 09:11:52 +0200 > >> >> >> Am 04.08.2014 22:47, schrieb Andrey Utkin: >>> This commit is a guesswork, but it seems to make sense to drop this >>> break, as otherwise the following line is never executed and becomes >>> dead code. And that following line actually saves the result of >>> local calculation by the pointer given in function argument. So the >>> proposed change makes sense if this code in the whole makes sense (but I >>> am unable to analyze it in the whole). >>> >>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81641 >>> Reported-by: David Binderman >>> Signed-off-by: Andrey Utkin >>> --- >>> arch/sparc/math-emu/math_32.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/sparc/math-emu/math_32.c b/arch/sparc/math-emu/math_32.c >>> index aa4d55b..5ce8f2f 100644 >>> --- a/arch/sparc/math-emu/math_32.c >>> +++ b/arch/sparc/math-emu/math_32.c >>> @@ -499,7 +499,7 @@ static int do_one_mathemu(u32 insn, unsigned long *pfsr, unsigned long *fregs) >>> case 0: fsr = *pfsr; >>> if (IR == -1) IR = 2; >>> /* fcc is always fcc0 */ >> >> The patch looks ok, but can somebody comment on this comment ? >> what "fcc" ? should it be a fsr ? > > It's the condition code field inside of the %fsr register. > > In 32-bit chips there is only one set of condition codes, whereas > on 64-bit chips there are 4 sets referred to as fcc0, fcc1, fcc2, > and fcc3. > > That's what this comment is talking about. > thx for info, would you mind to add your explanation ? It is much mor helpful that the comment right now. re, wh