From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 10/15] scsi: fix decimal printf format specifiers prefixed with 0x Date: Wed, 06 Aug 2014 09:21:26 +0200 Message-ID: <53E1D776.90300@suse.de> References: <1407300209-32745-1-git-send-email-hans@hanshq.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34405 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754553AbaHFHV2 (ORCPT ); Wed, 6 Aug 2014 03:21:28 -0400 In-Reply-To: <1407300209-32745-1-git-send-email-hans@hanshq.net> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hans Wennborg , JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org On 08/06/2014 06:43 AM, Hans Wennborg wrote: > The prefix suggests the number should be printed in hex, so use > the %x specifier to do that. > > Found by using regex suggested by Joe Perches. > > Signed-off-by: Hans Wennborg > --- > drivers/scsi/cxgbi/libcxgbi.c | 2 +- > drivers/scsi/nsp32.c | 2 +- > drivers/scsi/qla2xxx/qla_target.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcx= gbi.c > index d65df6d..4cc9787 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -1807,7 +1807,7 @@ static void csk_return_rx_credits(struct cxgbi_= sock *csk, int copied) > u32 credits; > > log_debug(1 << CXGBI_DBG_PDU_RX, > - "csk 0x%p,%u,0x%lu,%u, seq %u, wup %u, thre %u, %u.\n", > + "csk 0x%p,%u,0x%lx,%u, seq %u, wup %u, thre %u, %u.\n", > csk, csk->state, csk->flags, csk->tid, csk->copied_seq, > csk->rcv_wup, cdev->rx_credit_thres, > cdev->rcv_win); > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c > index 50b086a..198f754 100644 > --- a/drivers/scsi/nsp32.c > +++ b/drivers/scsi/nsp32.c > @@ -915,7 +915,7 @@ static int nsp32_queuecommand_lck(struct scsi_cmn= d *SCpnt, void (*done)(struct s > int ret; > > nsp32_dbg(NSP32_DEBUG_QUEUECOMMAND, > - "enter. target: 0x%x LUN: 0x%llu cmnd: 0x%x cmndlen: 0x%x " > + "enter. target: 0x%x LUN: 0x%llx cmnd: 0x%x cmndlen: 0x%x " > "use_sg: 0x%x reqbuf: 0x%lx reqlen: 0x%x", > SCpnt->device->id, SCpnt->device->lun, SCpnt->cmnd[0], SCpnt->c= md_len, > scsi_sg_count(SCpnt), scsi_sglist(SCpnt), scsi_bufflen(SCpnt)); > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx= /qla_target.c > index e632e14..aebe62c 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -2503,7 +2503,7 @@ qlt_handle_dif_error(struct scsi_qla_host *vha,= struct qla_tgt_cmd *cmd, > "iocb(s) %p Returned STATUS.\n", sts); > > ql_dbg(ql_dbg_tgt, vha, 0xf075, > - "dif check TGT cdb 0x%x lba 0x%llu: [Actual|Expected] Ref Tag[0= x%x|0x%x], App Tag [0x%x|0x%x], Guard [0x%x|0x%x]\n", > + "dif check TGT cdb 0x%x lba 0x%llx: [Actual|Expected] Ref Tag[0= x%x|0x%x], App Tag [0x%x|0x%x], Guard [0x%x|0x%x]\n", > cmd->atio.u.isp24.fcp_cmnd.cdb[0], lba, > a_ref_tag, e_ref_tag, a_app_tag, e_app_tag, a_guard, e_guard); > > Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754861AbaHFHV3 (ORCPT ); Wed, 6 Aug 2014 03:21:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34405 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754553AbaHFHV2 (ORCPT ); Wed, 6 Aug 2014 03:21:28 -0400 Message-ID: <53E1D776.90300@suse.de> Date: Wed, 06 Aug 2014 09:21:26 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Hans Wennborg , JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/15] scsi: fix decimal printf format specifiers prefixed with 0x References: <1407300209-32745-1-git-send-email-hans@hanshq.net> In-Reply-To: <1407300209-32745-1-git-send-email-hans@hanshq.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06/2014 06:43 AM, Hans Wennborg wrote: > The prefix suggests the number should be printed in hex, so use > the %x specifier to do that. > > Found by using regex suggested by Joe Perches. > > Signed-off-by: Hans Wennborg > --- > drivers/scsi/cxgbi/libcxgbi.c | 2 +- > drivers/scsi/nsp32.c | 2 +- > drivers/scsi/qla2xxx/qla_target.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > index d65df6d..4cc9787 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -1807,7 +1807,7 @@ static void csk_return_rx_credits(struct cxgbi_sock *csk, int copied) > u32 credits; > > log_debug(1 << CXGBI_DBG_PDU_RX, > - "csk 0x%p,%u,0x%lu,%u, seq %u, wup %u, thre %u, %u.\n", > + "csk 0x%p,%u,0x%lx,%u, seq %u, wup %u, thre %u, %u.\n", > csk, csk->state, csk->flags, csk->tid, csk->copied_seq, > csk->rcv_wup, cdev->rx_credit_thres, > cdev->rcv_win); > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c > index 50b086a..198f754 100644 > --- a/drivers/scsi/nsp32.c > +++ b/drivers/scsi/nsp32.c > @@ -915,7 +915,7 @@ static int nsp32_queuecommand_lck(struct scsi_cmnd *SCpnt, void (*done)(struct s > int ret; > > nsp32_dbg(NSP32_DEBUG_QUEUECOMMAND, > - "enter. target: 0x%x LUN: 0x%llu cmnd: 0x%x cmndlen: 0x%x " > + "enter. target: 0x%x LUN: 0x%llx cmnd: 0x%x cmndlen: 0x%x " > "use_sg: 0x%x reqbuf: 0x%lx reqlen: 0x%x", > SCpnt->device->id, SCpnt->device->lun, SCpnt->cmnd[0], SCpnt->cmd_len, > scsi_sg_count(SCpnt), scsi_sglist(SCpnt), scsi_bufflen(SCpnt)); > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index e632e14..aebe62c 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -2503,7 +2503,7 @@ qlt_handle_dif_error(struct scsi_qla_host *vha, struct qla_tgt_cmd *cmd, > "iocb(s) %p Returned STATUS.\n", sts); > > ql_dbg(ql_dbg_tgt, vha, 0xf075, > - "dif check TGT cdb 0x%x lba 0x%llu: [Actual|Expected] Ref Tag[0x%x|0x%x], App Tag [0x%x|0x%x], Guard [0x%x|0x%x]\n", > + "dif check TGT cdb 0x%x lba 0x%llx: [Actual|Expected] Ref Tag[0x%x|0x%x], App Tag [0x%x|0x%x], Guard [0x%x|0x%x]\n", > cmd->atio.u.isp24.fcp_cmnd.cdb[0], lba, > a_ref_tag, e_ref_tag, a_app_tag, e_app_tag, a_guard, e_guard); > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)