All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: keir@xen.org, Jan Beulich <JBeulich@suse.com>
Subject: Re: Possible problem emulating movntq, movss
Date: Wed, 06 Aug 2014 10:22:00 +0100	[thread overview]
Message-ID: <53E1F3B8.9090103@citrix.com> (raw)
In-Reply-To: <53E1EDE1.5040207@bitdefender.com>

On 06/08/2014 09:57, Razvan Cojocaru wrote:
> Hello,
>
> We found that our HVM guests froze when trying to emulate movntq
> instructions. The solution seems to be to replace "goto done;" with
> "break;" at line 4191 (when handling "case 0x7f:") in
> xen/arch/x86/x86_emulate/x86_emulate.c. Otherwise the writeback part
> doesn't happen.
>
> If you're happy with the fix I can prepare a patch, otherwise please let
> me know if we're missing something.
>
>
> Thanks,
> Razvan Cojocaru

I can't comment on the fix right now, but will take a look at it in due
course.

If you are making a change, please can you add a testcase for movntq and
movss to tools/tests/x86_emulator/test_x86_emulator.c which is the
unittest harness for x86_emulate.

~Andrew

  reply	other threads:[~2014-08-06  9:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  8:57 Possible problem emulating movntq, movss Razvan Cojocaru
2014-08-06  9:22 ` Andrew Cooper [this message]
2014-08-06  9:54 ` Jan Beulich
2014-08-06 10:39   ` Razvan Cojocaru
2014-08-06 10:47   ` Andrei LUTAS
2014-08-06 11:05     ` Andrew Cooper
2014-08-06 11:22       ` Razvan Cojocaru
2014-08-06 12:16     ` Jan Beulich
2014-08-06 12:50       ` Jan Beulich
2014-08-07  8:09         ` Razvan Cojocaru
2014-08-06 12:29     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E1F3B8.9090103@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=rcojocaru@bitdefender.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.