From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 02/21] xen: guestcopy: Provide an helper
 to safely copy string from guest
Date: Wed, 06 Aug 2014 15:18:36 +0100
Message-ID: <53E2393C.1050609@linaro.org>
References: <1406818852-31856-1-git-send-email-julien.grall@linaro.org>
	<1406818852-31856-3-git-send-email-julien.grall@linaro.org>
	<53DB6E9E02000078000284F9@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1XF23A-0001uK-1q
	for xen-devel@lists.xenproject.org; Wed, 06 Aug 2014 14:18:44 +0000
Received: by mail-we0-f176.google.com with SMTP id q58so2696816wes.21
	for <xen-devel@lists.xenproject.org>;
	Wed, 06 Aug 2014 07:18:42 -0700 (PDT)
In-Reply-To: <53DB6E9E02000078000284F9@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, ian.campbell@citrix.com, tim@xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

Hi Jan,

On 08/01/2014 09:40 AM, Jan Beulich wrote:
>>>> On 31.07.14 at 17:00, <julien.grall@linaro.org> wrote:
>> --- /dev/null
>> +++ b/xen/common/guestcopy.c
>> @@ -0,0 +1,29 @@
>> +#include <xen/config.h>
>> +#include <xen/lib.h>
>> +#include <xen/guest_access.h>
>> +
>> +/* The function copies a string from the guest and add a NUL-terminated to
>> + * make sure the string is correctly finished. */
> 
> "... and adds a NUL-terminator ...". Also not sure about "finished"
> here. And please fix the comment style.

Will fix it in the next version.

>> +int safe_copy_string_from_guest(XEN_GUEST_HANDLE(char) u_buf, char **buf,
>> +                                unsigned long size, unsigned long max_size)
> 
> size_t please.

Will do.

> Further I think this function would benefit from using the definitions
> in xen/err.h, eliminating the need to return the buffer pointer via
> indirection.

Good idea. I will use this solution in the next version.

Regards,

-- 
Julien Grall