From: Karsten Blees <karsten.blees@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] pack-bitmap: do not use gcc packed attribute
Date: Wed, 06 Aug 2014 20:58:36 +0200 [thread overview]
Message-ID: <53E27ADC.4070501@gmail.com> (raw)
In-Reply-To: <20140805184724.GA10369@peff.net>
Am 05.08.2014 20:47, schrieb Jeff King:
> On Mon, Aug 04, 2014 at 09:19:46PM +0200, Karsten Blees wrote:
>
>> Hmm, I wonder if it wouldn't be simpler to read / write the desired on-disk
>> structure directly, without copying to a uchar[6] first.
>
> Probably. My initial attempt was to keep together the read/write logic
> about which sizes each item is, but I think the result ended up
> unnecessarily verbose and harder to follow.
>
Yeah, having read / write logic in different files is confusing, esp. when
not using structs to define the file format.
>> Here's what I came up with (just a sketch, commit message is lacky and the
>> helper functions deserve a better place / name):
>
> I like it. Want to clean it up and submit in place of mine?
>
Will do, but it will have to wait till next week.
> -Peff
>
next prev parent reply other threads:[~2014-08-06 18:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 17:17 struct hashmap_entry packing Jeff King
2014-07-29 20:40 ` Karsten Blees
2014-08-01 22:37 ` Jeff King
2014-08-01 23:10 ` [PATCH] pack-bitmap: do not use gcc packed attribute Jeff King
2014-08-01 23:12 ` Jeff King
2014-08-04 19:19 ` Karsten Blees
2014-08-05 18:38 ` Vicent Martí
2014-08-05 18:47 ` Jeff King
2014-08-06 18:58 ` Karsten Blees [this message]
2014-08-06 19:32 ` Junio C Hamano
2014-08-04 19:20 ` struct hashmap_entry packing Karsten Blees
2014-08-05 18:51 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2014-11-26 23:09 What's cooking in git.git (Nov 2014, #04; Wed, 26) Junio C Hamano
2014-11-27 5:24 ` [PATCH] pack-bitmap: do not use gcc packed attribute Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E27ADC.4070501@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.