From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <ilya.dryomov@inktank.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] rbd: rework rbd_request_fn()
Date: Wed, 06 Aug 2014 14:10:58 -0500 [thread overview]
Message-ID: <53E27DC2.2090009@ieee.org> (raw)
In-Reply-To: <CALFYKtDyDawX87v6uudM-_VCBTB0j6r1SPA+P_krA3V22iy-EA@mail.gmail.com>
On 08/06/2014 02:09 PM, Ilya Dryomov wrote:
>>> Off topic... If you supply "--patience" to your git diff command
>>> >> you'll get an easier-to-read result in some cases (like this one).
>>> >> If you like that you can just do:
>>> >> git config --global --add diff.algorithm patience
>> >
>> > I'm generally using (and used to review this patch in particular)
>> > --histogram. In my experience it gives slightly better results than
>> > --patience. Didn't think of putting it into .gitconfig though.
> Looks like --histogram beats --patience in this case too.
> alloc_workqueue() hunk is much better, otherwise identical.
I didn't know about histogram... I guess I should update
my git config.
-Alex
next prev parent reply other threads:[~2014-08-06 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 7:38 [PATCH] rbd: rework rbd_request_fn() Ilya Dryomov
2014-08-05 7:44 ` Christoph Hellwig
2014-08-06 18:32 ` Alex Elder
2014-08-06 19:06 ` Ilya Dryomov
2014-08-06 19:09 ` Ilya Dryomov
2014-08-06 19:10 ` Alex Elder [this message]
2014-08-07 7:21 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E27DC2.2090009@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ilya.dryomov@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.