From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]:3531 "EHLO smtp-vbr9.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbaHGGvc (ORCPT ); Thu, 7 Aug 2014 02:51:32 -0400 Message-ID: <53E321E5.7080601@xs4all.nl> Date: Thu, 07 Aug 2014 08:51:17 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Sakari Ailus , linux-media@vger.kernel.org Subject: Re: [PATCH v2 1/1] v4l: Event documentation fixes References: <53E1CEA2.3080503@xs4all.nl> <1407307928-13652-1-git-send-email-sakari.ailus@linux.intel.com> <53E321A8.9070304@xs4all.nl> In-Reply-To: <53E321A8.9070304@xs4all.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/07/2014 08:50 AM, Hans Verkuil wrote: > On 08/06/2014 08:52 AM, Sakari Ailus wrote: >> Constify event type constants and correct motion detection event number >> (it's 6, not 5). >> >> Signed-off-by: Sakari Ailus > > Acked-by: Hans Verkuil Hmm, I did that already. Oh well, you can never have too many acks :-) > >> --- >> Thanks for the review, Hans! >> >> Since v1: >> >> - No line breaks between and . No other changes. >> >> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++--- >> Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +- >> 2 files changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml >> index cb77325..b036f89 100644 >> --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml >> +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml >> @@ -76,21 +76,22 @@ >> >> &v4l2-event-vsync; >> vsync >> - Event data for event V4L2_EVENT_VSYNC. >> + Event data for event V4L2_EVENT_VSYNC. >> >> >> >> >> &v4l2-event-ctrl; >> ctrl >> - Event data for event V4L2_EVENT_CTRL. >> + Event data for event V4L2_EVENT_CTRL. >> >> >> >> >> &v4l2-event-frame-sync; >> frame_sync >> - Event data for event V4L2_EVENT_FRAME_SYNC. >> + Event data for event >> + V4L2_EVENT_FRAME_SYNC. >> >> >> >> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml >> index 9f60956..d7c9365 100644 >> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml >> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml >> @@ -176,7 +176,7 @@ >> >> >> V4L2_EVENT_MOTION_DET >> - 5 >> + 6 >> >> Triggered whenever the motion detection state for one or more of the regions >> changes. This event has a &v4l2-event-motion-det; associated with it. >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >