From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFLxO-0007KH-0q for qemu-devel@nongnu.org; Thu, 07 Aug 2014 07:34:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFLxJ-0005Qc-64 for qemu-devel@nongnu.org; Thu, 07 Aug 2014 07:34:05 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:31412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFLxI-0005Ny-Js for qemu-devel@nongnu.org; Thu, 07 Aug 2014 07:34:01 -0400 Message-ID: <53E36409.3070007@huawei.com> Date: Thu, 7 Aug 2014 19:33:29 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1407398512-20780-1-git-send-email-zhang.zhanghailiang@huawei.com> <1407398512-20780-9-git-send-email-zhang.zhanghailiang@huawei.com> <33183CC9F5247A488A2544077AF1902086C2900B@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF1902086C2900B@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by fopen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "kwolf@redhat.com" , "lkurusa@redhat.com" , "mst@redhat.com" , "jan.kiszka@siemens.com" , "riku.voipio@iki.fi" , "mjt@tls.msk.ru" , "qemu-devel@nongnu.org" , "Huangpeng (Peter)" , "stefanha@redhat.com" , "Liuli (I)" , Luonengjun , "pbonzini@redhat.com" , "lcapitulino@redhat.com" , "alex.bennee@linaro.org" , "rth@twiddle.net" On 2014/8/7 19:14, Gonglei (Arei) wrote: >> Subject: [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by >> fopen() >> >> The function fopen() may fail, so check its return value. >> >> Signed-off-by: zhanghailiang >> Signed-off-by: Li Liu >> --- >> qtest.c | 5 +++++ >> tests/bios-tables-test.c | 2 ++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/qtest.c b/qtest.c >> index 04a6dc1..ae9b636 100644 >> --- a/qtest.c >> +++ b/qtest.c >> @@ -536,6 +536,11 @@ void qtest_init(const char *qtest_chrdev, const char >> *qtest_log, Error **errp) >> if (qtest_log) { >> if (strcmp(qtest_log, "none") != 0) { >> qtest_log_fp = fopen(qtest_log, "w+"); >> + if (qtest_log_fp == NULL) { >> + error_setg(errp, "Failed to open log file for qtest: \"%s\"", >> + qtest_log); >> + return; >> + } > > Actually I don't think this check is necessary, because the qtest_log_fp will be checked > where it is used. > Hmm, you are right! I will remove the changes! Thanks, zhanghailiang >> } >> } else { >> qtest_log_fp = stderr; >> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c >> index 045eb27..6a357c0 100644 >> --- a/tests/bios-tables-test.c >> +++ b/tests/bios-tables-test.c >> @@ -790,6 +790,8 @@ int main(int argc, char *argv[]) >> const char *arch = qtest_get_arch(); >> FILE *f = fopen(disk, "w"); >> int ret; >> + >> + g_assert(f != NULL); >> fwrite(boot_sector, 1, sizeof boot_sector, f); >> fclose(f); >> >> -- >> 1.7.12.4 >>