Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

[Tomas Henzl <thenzl@redhat.com>]

On 08/04/2014 06:00 AM, Ching Huang wrote:
> On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote:
>>> @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru
>>>  		arcmsr_handle_virtual_command(acb, cmd);
>>>  		return 0;
>>>  	}
>>> -	if (atomic_read(&acb->ccboutstandingcount) >=
>>> -			ARCMSR_MAX_OUTSTANDING_CMD)
>>> +	if (atomic_read(&acb->ccboutstandingcount) >= acb->maxOutstanding)
>>>  		return SCSI_MLQUEUE_HOST_BUSY;
>> The scsi midlayer already takes care of this check for you.
>>
> Hello Christoph,
>
> We have 4 types of Adapter that some adpaters have command queue less
> than ARCMSR_MAX_OUTSTANDING_CMD.
> So we have to check outstanding command number here.

I think you could set the correct value of can_queue in arcmsr_probe
after you have read the firmware spec.

>
> Thanks for your comment.
> Ching
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html