From: Richard Henderson <rth@twiddle.net>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, lkurusa@redhat.com, mst@redhat.com,
jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru,
peter.huangpeng@huawei.com, lcapitulino@redhat.com,
stefanha@redhat.com, luonengjun@huawei.com, pbonzini@redhat.com,
alex.bennee@linaro.org
Subject: Re: [Qemu-devel] [PATCH v3 07/10] linux-user: check return value of malloc()
Date: Thu, 07 Aug 2014 07:19:02 -1000 [thread overview]
Message-ID: <53E3B506.5070501@twiddle.net> (raw)
In-Reply-To: <1407398512-20780-8-git-send-email-zhang.zhanghailiang@huawei.com>
On 08/06/2014 10:01 PM, zhanghailiang wrote:
> if (!lock_user_struct(VERIFY_READ, target_mb, msgp, 0))
> return -TARGET_EFAULT;
> host_mb = malloc(msgsz+sizeof(long));
> + if (!host_mb) {
> + return -TARGET_ENOMEM;
> + }
lock_user allocates memory; returning from the middle leaks it.
r~
next prev parent reply other threads:[~2014-08-07 17:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 8:01 [Qemu-devel] [PATCH v3 00/10] fix three bugs about use-after-free and several api abuse zhanghailiang
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 01/10] l2cap: fix access freed memory zhanghailiang
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 02/10] monitor: " zhanghailiang
2014-08-07 11:01 ` Gonglei (Arei)
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 03/10] virtio-blk: fix reference a pointer which might be freed zhanghailiang
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 04/10] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-07 8:53 ` Levente Kurusa
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 05/10] util/path: check return value of malloc() zhanghailiang
2014-08-07 11:04 ` Gonglei (Arei)
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 06/10] slirp: " zhanghailiang
2014-08-07 11:08 ` Gonglei (Arei)
2014-08-07 11:25 ` zhanghailiang
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 07/10] linux-user: " zhanghailiang
2014-08-07 17:19 ` Richard Henderson [this message]
2014-08-08 1:21 ` zhanghailiang
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by fopen() zhanghailiang
2014-08-07 11:14 ` Gonglei (Arei)
2014-08-07 11:33 ` zhanghailiang
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 09/10] tcg: check return value of fopen() zhanghailiang
2014-08-07 8:01 ` [Qemu-devel] [PATCH v3 10/10] block/vvfat: fix setbuf stream parameter may be NULL zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E3B506.5070501@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lkurusa@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.