From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XFRLX-00046s-DE
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 13:19:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XFRLO-0002pE-Bc
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 13:19:23 -0400
Received: from mail-qa0-x22f.google.com ([2607:f8b0:400d:c00::22f]:45342)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XFRLO-0002pA-7W
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 13:19:14 -0400
Received: by mail-qa0-f47.google.com with SMTP id i13so4235301qae.20
	for <qemu-devel@nongnu.org>; Thu, 07 Aug 2014 10:19:13 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53E3B506.5070501@twiddle.net>
Date: Thu, 07 Aug 2014 07:19:02 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1407398512-20780-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1407398512-20780-8-git-send-email-zhang.zhanghailiang@huawei.com>
In-Reply-To: <1407398512-20780-8-git-send-email-zhang.zhanghailiang@huawei.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 07/10] linux-user: check return value of
	malloc()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, lkurusa@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, peter.huangpeng@huawei.com, lcapitulino@redhat.com, stefanha@redhat.com, luonengjun@huawei.com, pbonzini@redhat.com, alex.bennee@linaro.org

On 08/06/2014 10:01 PM, zhanghailiang wrote:
>      if (!lock_user_struct(VERIFY_READ, target_mb, msgp, 0))
>          return -TARGET_EFAULT;
>      host_mb = malloc(msgsz+sizeof(long));
> +    if (!host_mb) {
> +        return -TARGET_ENOMEM;
> +    }

lock_user allocates memory; returning from the middle leaks it.


r~