From: David Daney <ddaney.cavm@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Wei.Yang@windriver.com, a.p.zijlstra@chello.nl, paulus@samba.org,
mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH v1] MIPS: perf: Mark pmu interupt IRQF_NO_THREAD
Date: Thu, 07 Aug 2014 10:33:40 -0700 [thread overview]
Message-ID: <53E3B874.80008@gmail.com> (raw)
In-Reply-To: <20140807114831.GB29898@linux-mips.org>
On 08/07/2014 04:48 AM, Ralf Baechle wrote:
> On Tue, Aug 05, 2014 at 01:37:47PM +0800, Wei.Yang@windriver.com wrote:
>
>> From: Yang Wei <Wei.Yang@windriver.com>
>>
>> In RT kernel, I ran into the following calltrace, so PMU interrupts cannot
>> be threaded
>>
>> in_atomic(): 1, irqs_disabled(): 1, pid: 0, name: swapper/0
>> INFO: lockdep is turned off.
>> Call Trace:
>> [<ffffffff8088595c>] dump_stack+0x1c/0x50
>> [<ffffffff801a958c>] __might_sleep+0x13c/0x148
>> [<ffffffff80891c54>] rt_spin_lock+0x3c/0xb0
>> [<ffffffff801ad29c>] __wake_up+0x3c/0x80
>> [<ffffffff80243ba4>] perf_event_wakeup+0x8c/0xf8
>> [<ffffffff80243c50>] perf_pending_event+0x40/0x78
>> [<ffffffff8023d88c>] irq_work_run+0x74/0xc0
>> [<ffffffff80152640>] mipsxx_pmu_handle_shared_irq+0x110/0x228
>> [<ffffffff8015276c>] mipsxx_pmu_handle_irq+0x14/0x30
>> [<ffffffff801ffda4>] handle_irq_event_percpu+0xbc/0x470
>> [<ffffffff80204478>] handle_percpu_irq+0x98/0xc8
>> [<ffffffff801ff284>] generic_handle_irq+0x4c/0x68
>> [<ffffffff8089748c>] do_IRQ+0x2c/0x48
>> [<ffffffff80105864>] plat_irq_dispatch+0x64/0xd0
>
> Hm... I don't see why based on this backtrace you concluce the
> handler needs to be marked IRQF_NO_THREAD. However there's another
> reason to mark it IRQF_NO_THREAD. IRQ threads may be rescheduled to
> other CPUs but this handler is fiddling with per-CPU resources.
>
Also by its nature, the profiling code needs synchronous access to the
register state of the interrupted code. If you are running on a
different thread, then I don't think this would be available.
> See https://patchwork.linux-mips.org/patch/2818/ for a similar
> scenario a few years ago.
>
> Ralf
>
>
prev parent reply other threads:[~2014-08-07 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 5:37 [PATCH v1] MIPS: perf: Mark pmu interupt IRQF_NO_THREAD Wei.Yang
2014-08-05 5:37 ` Wei.Yang
2014-08-07 11:48 ` Ralf Baechle
2014-08-07 17:33 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E3B874.80008@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=Wei.Yang@windriver.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.