From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XFYsq-0008QM-71
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 21:22:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XFYsk-000626-0x
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 21:22:16 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:33750)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XFYsj-00061w-F7
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 21:22:09 -0400
Message-ID: <53E4260E.5060407@huawei.com>
Date: Fri, 8 Aug 2014 09:21:18 +0800
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
References: <1407398512-20780-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1407398512-20780-8-git-send-email-zhang.zhanghailiang@huawei.com>
	<53E3B506.5070501@twiddle.net>
In-Reply-To: <53E3B506.5070501@twiddle.net>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 07/10] linux-user: check return value of
	malloc()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: kwolf@redhat.com, lkurusa@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, luonengjun@huawei.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, alex.bennee@linaro.org

On 2014/8/8 1:19, Richard Henderson wrote:
> On 08/06/2014 10:01 PM, zhanghailiang wrote:
>>       if (!lock_user_struct(VERIFY_READ, target_mb, msgp, 0))
>>           return -TARGET_EFAULT;
>>       host_mb = malloc(msgsz+sizeof(long));
>> +    if (!host_mb) {
>> +        return -TARGET_ENOMEM;
>> +    }
>
> lock_user allocates memory; returning from the middle leaks it.
>

Hmm, it is my fault, i will correct it. Thanks, Richard.

Best regards,
zhanghailiang