All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/1] xen:include:asm-x86:e820: just covert nr_map with unsigned int
Date: Fri, 08 Aug 2014 15:26:18 +0800	[thread overview]
Message-ID: <53E47B9A.60905@intel.com> (raw)
In-Reply-To: <53E4952B020000780002A5EF@mail.emea.novell.com>

On 2014/8/8 15:15, Jan Beulich wrote:
>>>> On 08.08.14 at 09:00, <tiejun.chen@intel.com> wrote:
>> This shouldn't ever be negative.
>
> This means nothing for the actual change, and makes me imply you did
> the change without checking it actually _is_ never negative in any of
> the uses.
>
> Also please cut down your patch title prefixes (not just here) to
> something reasonable.
>

What about this?

xen:e820map: just convert nr_map with unsigned int

nr_map is used to represent the amount of e820entry in e820 so it
shouldn't be negative.

Thanks
Tiejun

  reply	other threads:[~2014-08-08  7:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08  7:00 [PATCH 1/1] xen:include:asm-x86:e820: just covert nr_map with unsigned int Tiejun Chen
2014-08-08  7:15 ` Jan Beulich
2014-08-08  7:26   ` Chen, Tiejun [this message]
2014-08-08  7:38     ` Jan Beulich
2014-08-08  7:54       ` Chen, Tiejun
2014-08-08  8:49         ` Jan Beulich
2014-08-08  9:06           ` Chen, Tiejun
2014-08-08  9:18             ` Jan Beulich
2014-08-08  9:31               ` Chen, Tiejun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E47B9A.60905@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.