From: Pramod Gurav <pramod.gurav@smartplayin.com>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: daniel.lezcano@linaro.org, khilman@linaro.org,
amit.kucheria@linaro.org, sboyd@codeaurora.org,
davidb@codeaurora.org, galak@codeaurora.org,
linux-arm-msm@vger.kernel.org, msivasub@codeaurora.org,
bryanh@codeaurora.org
Subject: Re: [RFC] [PATCH 01/13] msm: scm: Move scm-boot files to drivers/soc and include/soc
Date: Fri, 08 Aug 2014 13:12:31 +0530 [thread overview]
Message-ID: <53E47F67.8050305@smartplayin.com> (raw)
In-Reply-To: <1407470722-23015-2-git-send-email-lina.iyer@linaro.org>
Hi Lina,
On Friday 08 August 2014 09:35 AM, Lina Iyer wrote:
> Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
> ---
> arch/arm/mach-qcom/Makefile | 1 -
> drivers/soc/qcom/Makefile | 2 +-
> {arch/arm/mach-qcom => drivers/soc/qcom}/scm-boot.c | 4 ++--
> {arch/arm/mach-qcom => include/soc/qcom}/scm-boot.h | 0
> 4 files changed, 3 insertions(+), 4 deletions(-)
> rename {arch/arm/mach-qcom => drivers/soc/qcom}/scm-boot.c (97%)
> rename {arch/arm/mach-qcom => include/soc/qcom}/scm-boot.h (100%)
There remain references to "scm-boot.h" in platsmp.c. Can we replace
them with "soc/qcom/scm-boot.h" in this same patch so that build does
not break with only applying this patch. I see these changes in "qcom:
platsmp: Enable deeper idle states for hotplug" hence build may not
break with all your patches. Correct if I am wrong.
Note: I am trying to apply these patches on top on rpm changes in
drivers/soc/qoc hence have to manual apply your patches. Also building
kernel after each patch and found the break.
>
> diff --git a/arch/arm/mach-qcom/Makefile b/arch/arm/mach-qcom/Makefile
> index db41e8c..e324375 100644
> --- a/arch/arm/mach-qcom/Makefile
> +++ b/arch/arm/mach-qcom/Makefile
> @@ -1,3 +1,2 @@
> obj-y := board.o
> obj-$(CONFIG_SMP) += platsmp.o
> -obj-$(CONFIG_QCOM_SCM) += scm-boot.o
> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
> index a39446d..70d52ed 100644
> --- a/drivers/soc/qcom/Makefile
> +++ b/drivers/soc/qcom/Makefile
> @@ -1,3 +1,3 @@
> obj-$(CONFIG_QCOM_GSBI) += qcom_gsbi.o
> CFLAGS_scm.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
> -obj-$(CONFIG_QCOM_SCM) += scm.o
> +obj-$(CONFIG_QCOM_SCM) += scm.o scm-boot.o
> diff --git a/arch/arm/mach-qcom/scm-boot.c b/drivers/soc/qcom/scm-boot.c
> similarity index 97%
> rename from arch/arm/mach-qcom/scm-boot.c
> rename to drivers/soc/qcom/scm-boot.c
> index 5add20e..60ff7b4 100644
> --- a/arch/arm/mach-qcom/scm-boot.c
> +++ b/drivers/soc/qcom/scm-boot.c
> @@ -17,9 +17,9 @@
>
> #include <linux/module.h>
> #include <linux/slab.h>
> -#include <soc/qcom/scm.h>
>
> -#include "scm-boot.h"
> +#include <soc/qcom/scm.h>
> +#include <soc/qcom/scm-boot.h>
>
> /*
> * Set the cold/warm boot address for one of the CPU cores.
> diff --git a/arch/arm/mach-qcom/scm-boot.h b/include/soc/qcom/scm-boot.h
> similarity index 100%
> rename from arch/arm/mach-qcom/scm-boot.h
> rename to include/soc/qcom/scm-boot.h
>
next prev parent reply other threads:[~2014-08-08 7:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 4:05 [RFC] [PATCH 00/13] QCOM: 8074 CPUIDLE driver Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 01/13] msm: scm: Move scm-boot files to drivers/soc and include/soc Lina Iyer
2014-08-08 7:42 ` Pramod Gurav [this message]
2014-08-08 14:39 ` Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 02/13] msm: scm: Add SCM warmboot flags for quad core targets Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 03/13] qcom: spm: Add Subsystem Power Manager driver for QCOM chipsets Lina Iyer
2014-08-08 9:18 ` Pramod Gurav
2014-08-08 10:07 ` Pramod Gurav
2014-08-08 14:31 ` Lina Iyer
2014-08-08 16:16 ` Kumar Gala
2014-08-08 21:53 ` Lina Iyer
2014-08-11 19:54 ` Kumar Gala
2014-08-11 20:40 ` Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 04/13] arm: dts: qcom: Add SPM device bindings for 8974 Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 05/13] qcom: msm-pm: Add cpu low power mode functions Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 06/13] qcom: msm-pm: Add support for hotplug and secondary startup Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 07/13] qcom: sleep-status: Add ability to recognize cpu power down state Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 08/13] arm: dts: qcom: Add device binding for sleep status Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 09/13] soc: qcom: Add QCOM Power management config Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 10/13] qcom: platsmp: Enable deeper idle states for hotplug Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 11/13] qcom: cpuidle: Add cpuidle driver for QCOM cpus Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 12/13] qcom: cpuidle: Add cpuidle device nodes for 8974 chipset Lina Iyer
2014-08-08 4:05 ` [RFC] [PATCH 13/13] qcom: cpuidle: Config option to enable QCOM cpuidle driver Lina Iyer
-- strict thread matches above, loose matches on Subject: below --
2014-08-08 4:00 [RFC] [PATCH 00/13] QCOM: 8087 CPUIDLE driver Lina Iyer
2014-08-08 4:00 ` [RFC] [PATCH 01/13] msm: scm: Move scm-boot files to drivers/soc and include/soc Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E47F67.8050305@smartplayin.com \
--to=pramod.gurav@smartplayin.com \
--cc=amit.kucheria@linaro.org \
--cc=bryanh@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=davidb@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=khilman@linaro.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=msivasub@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.