Re: [PATCH v3 2/2] tools/xen-access: Print gla valid/fault information

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 08/08/2014 00:12, Tamas K Lengyel wrote:
> Extend the print-out of the memory violations to show gla valid/fault information.
>
> v2: Update to new fields and change printing 1/0 to y/n.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
> ---
>  tools/tests/xen-access/xen-access.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
> index 090df5f..378b205 100644
> --- a/tools/tests/xen-access/xen-access.c
> +++ b/tools/tests/xen-access/xen-access.c
> @@ -566,13 +566,16 @@ int main(int argc, char *argv[])
>                  }
>  
>                  printf("PAGE ACCESS: %c%c%c for GFN %"PRIx64" (offset %06"
> -                       PRIx64") gla %016"PRIx64" (vcpu %d)\n",
> +                       PRIx64") gla %016"PRIx64" (valid: %c) fault in gpt: %c gpa has gla: %c (vcpu %d)\n",

As you likely need to repsin this patch, please correct %d to %u as
req.vcpu_id is unsigned.

~Andrew

>                         req.access_r ? 'r' : '-',
>                         req.access_w ? 'w' : '-',
>                         req.access_x ? 'x' : '-',
>                         req.gfn,
>                         req.offset,
>                         req.gla,
> +                       req.gla_valid ? 'y' : 'n',
> +                       req.fault_in_gpt ? 'y' : 'n',
> +                       req.fault_gla ? 'y': 'n',
>                         req.vcpu_id);
>  
>                  if ( default_access != after_first_access )