From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pramod Gurav Subject: Re: [RFC] [PATCH 03/13] qcom: spm: Add Subsystem Power Manager driver for QCOM chipsets Date: Fri, 08 Aug 2014 14:48:35 +0530 Message-ID: <53E495EB.2020702@smartplayin.com> References: <1407470722-23015-1-git-send-email-lina.iyer@linaro.org> <1407470722-23015-4-git-send-email-lina.iyer@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp102.ord1c.emailsrvr.com ([108.166.43.102]:59377 "EHLO smtp102.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755914AbaHHJPP (ORCPT ); Fri, 8 Aug 2014 05:15:15 -0400 In-Reply-To: <1407470722-23015-4-git-send-email-lina.iyer@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lina Iyer Cc: daniel.lezcano@linaro.org, khilman@linaro.org, amit.kucheria@linaro.org, sboyd@codeaurora.org, davidb@codeaurora.org, galak@codeaurora.org, linux-arm-msm@vger.kernel.org, msivasub@codeaurora.org, bryanh@codeaurora.org, Praveen Chidamabram , Murali Nalajala Hi Lina, On Friday 08 August 2014 09:35 AM, Lina Iyer wrote: > Qualcomm chipsets use an separate h/w block to control the logic around > the processor cores (cpu and L2). The SPM h/w block regulates power to > the cores and controls the power when the core enter low power modes. > > Each core has its own instance of SPM. The SPM has the following key > functions > - Configure the h/w dependencies when entering low power modes > - Wait for interrupt and wake up on interrupt > - Ensure the dependencies are ready before bringing the core out > of sleep > - Regulating voltage to the core, interfacing with the PMIC. > - Optimize power based on runtime recommendations. > > The driver identifies and configures the SPMs, by reading the nodes and > the register values from the devicetree. The SPMs need to be configured > to allow the processor to be idled in a low power state. 22 30 0f]; > + }; > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index 70d52ed..3de7ed9 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -1,3 +1,5 @@ > obj-$(CONFIG_QCOM_GSBI) += qcom_gsbi.o > +obj-$(CONFIG_QCOM_PM) += spm_devices.o spm.o Are we missing a Kconfig entry for CONFIG_QCOM_PM? This won't compile. > + > CFLAGS_scm.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1) > obj-$(CONFIG_QCOM_SCM) += scm.o scm-boot.o > +#endif /* defined (CONFIG_QCOM_PM) */ > +#endif /* __MSM_SPM_H */ >