From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFhho-0002aX-Ou for qemu-devel@nongnu.org; Fri, 08 Aug 2014 06:47:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFhhj-0007t0-Tq for qemu-devel@nongnu.org; Fri, 08 Aug 2014 06:47:28 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:47200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFhhj-0007oV-6I for qemu-devel@nongnu.org; Fri, 08 Aug 2014 06:47:23 -0400 Message-ID: <53E4AA81.6080309@huawei.com> Date: Fri, 8 Aug 2014 18:46:25 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com> <1407489672-12212-9-git-send-email-zhang.zhanghailiang@huawei.com> <87lhqzjofo.fsf@linaro.org> In-Reply-To: <87lhqzjofo.fsf@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: kwolf@redhat.com, lkurusa@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, Li Liu , luonengjun@huawei.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, rth@twiddle.net On 2014/8/8 17:51, Alex Bennée wrote: > > zhanghailiang writes: > >> The function fopen() may fail, so check its return value. >> >> Signed-off-by: zhanghailiang >> Signed-off-by: Li Liu >> --- >> tests/bios-tables-test.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c >> index 045eb27..6a357c0 100644 >> --- a/tests/bios-tables-test.c >> +++ b/tests/bios-tables-test.c >> @@ -790,6 +790,8 @@ int main(int argc, char *argv[]) >> const char *arch = qtest_get_arch(); >> FILE *f = fopen(disk, "w"); >> int ret; >> + >> + g_assert(f != NULL); >> fwrite(boot_sector, 1, sizeof boot_sector, f); >> fclose(f); > > Incorrect use of g_assert. An assertion is a test for things that > shouldn't happen so in this case it's saying: > > * this function assumes files will always successfully open > > Which is not the case. It's quite possible that a fopen will fail and > the correct behaviour is to handle the error, not assert out. > > Good catch! That is a low grade fault, i will correct it! Thanks, Alex Best regards, zhanghailiang