Re: [Qemu-devel] [PATCH] block: add watermark event

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On 08/08/2014 02:01 AM, Francesco Romani wrote:

>>>> So let the block-set-watermark caller pass an absolute sector number
>>>> instead.  It keeps things simple for both QEMU and thin provisioning
>>>> manager.
>>>
>>> No sector numbers in external interfaces, please. These units of 512
>>> bytes are completely arbitrary and don't make any sense. I hope to get
>>> rid of BDRV_SECTOR_* eventually even internally.
>>>
>>> So for external APIs, please use bytes instead.
>>
>> I agree and forgot about that.  Please use bytes instead of sectors or a
>> percentage.
>>
> 
> Thanks everyone for the great feedback received!
> 
> I'll post asap a new patch addressing all the comments.
> 
> I'll also change the name because 'watermark' may be misleading/wrong jargon :)
> (http://en.wikipedia.org/wiki/Watermark)

Is "threshold" a better name than "watermark"?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]