From: David L Stevens <david.stevens@oracle.com>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH sparc] ldc_connect() should not return EINVAL when handshake is in progress.
Date: Fri, 08 Aug 2014 13:55:55 +0000 [thread overview]
Message-ID: <53E4D6EB.6060809@oracle.com> (raw)
In-Reply-To: <20140801135040.GE19031@oracle.com>
On 08/08/2014 01:26 AM, David Miller wrote:
> Now, besides taking the error path in vnet_start_xmit() and dropping
> the packet, we need to think about what we should do subsequently when
> this condition triggers.
>
> We probably want to take the carrier down via netif_carrier_off(), and
> then when we see the head pointer advancing (I guess via
> vnet_event()'s logic), the networking driver can netif_carrir_on() in
> response.
Aren't we talking about one ldc port (out of many) for the device here?
I'm not sure we want to drop carrier if only one port isn't making
progress, unless maybe that's the only switch port.
+-DLS
next prev parent reply other threads:[~2014-08-08 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 13:50 [PATCH sparc] ldc_connect() should not return EINVAL when handshake is in progress Sowmini Varadhan
2014-08-05 3:22 ` David Miller
2014-08-05 13:52 ` Sowmini Varadhan
2014-08-07 6:00 ` David Miller
2014-08-07 20:17 ` Sowmini Varadhan
2014-08-08 5:26 ` David Miller
2014-08-08 13:55 ` David L Stevens [this message]
2014-08-08 17:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E4D6EB.6060809@oracle.com \
--to=david.stevens@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.