From mboxrd@z Thu Jan 1 00:00:00 1970 From: David L Stevens Date: Fri, 08 Aug 2014 13:55:55 +0000 Subject: Re: [PATCH sparc] ldc_connect() should not return EINVAL when handshake is in progress. Message-Id: <53E4D6EB.6060809@oracle.com> List-Id: References: <20140801135040.GE19031@oracle.com> In-Reply-To: <20140801135040.GE19031@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sparclinux@vger.kernel.org On 08/08/2014 01:26 AM, David Miller wrote: > Now, besides taking the error path in vnet_start_xmit() and dropping > the packet, we need to think about what we should do subsequently when > this condition triggers. > > We probably want to take the carrier down via netif_carrier_off(), and > then when we see the head pointer advancing (I guess via > vnet_event()'s logic), the networking driver can netif_carrir_on() in > response. Aren't we talking about one ldc port (out of many) for the device here? I'm not sure we want to drop carrier if only one port isn't making progress, unless maybe that's the only switch port. +-DLS