From: Denys Vlasenko <dvlasenk@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 8/8] x86: add comments about various syscall instructions, no code changes
Date: Fri, 08 Aug 2014 18:18:37 +0200 [thread overview]
Message-ID: <53E4F85D.2010001@redhat.com> (raw)
In-Reply-To: <20140805195821.GA30908@redhat.com>
On 08/05/2014 09:58 PM, Oleg Nesterov wrote:
> On 08/05, Denys Vlasenko wrote:
>>
>> This patch adds comments which explain in detail
>> what registers are modified by each of these instructions.
>> The comments are placed immediately before corresponding
>> entry and exit points.
>
> This is great ;)
I just discovered that I misunderstood how _exactly_
SYSCALL decides whether to save rflags to r11 or not.
(Wrote an actual testcase for 32bit -> 64bit SYSCALL
transition. Practice always trumps theory, doesn't it? ;)
So I had to fix my comments in this patch. I guess
I need to send v4 of the patchset now...
next prev parent reply other threads:[~2014-08-08 16:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 14:52 [PATCH v3 0/8] x86: entry_64.S: always allocate complete "struct pt_regs" Denys Vlasenko
2014-08-05 14:52 ` [PATCH 1/8] x86: entry_64.S: delete unused code Denys Vlasenko
2014-08-05 14:52 ` [PATCH 2/8] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET Denys Vlasenko
2014-08-05 14:52 ` [PATCH 3/8] x86: open-code register save/restore in trace_hardirqs thunks Denys Vlasenko
2014-08-05 14:52 ` [PATCH 4/8] x86: entry_64.S: fold SAVE_ARGS_IRQ macro into its sole user Denys Vlasenko
2014-08-05 14:52 ` [PATCH 5/8] x86: entry_64.S: always allocate complete "struct pt_regs" Denys Vlasenko
2014-08-05 14:52 ` [PATCH 6/8] x86: mass removal of ARGOFFSET Denys Vlasenko
2014-08-05 14:52 ` [PATCH 7/8] x86: rename some macros and labels, no code changes Denys Vlasenko
2014-08-05 14:52 ` [PATCH 8/8] x86: add comments about various syscall instructions, " Denys Vlasenko
2014-08-05 19:58 ` Oleg Nesterov
2014-08-08 16:18 ` Denys Vlasenko [this message]
2014-08-05 20:13 ` [PATCH v3 0/8] x86: entry_64.S: always allocate complete "struct pt_regs" H. Peter Anvin
2014-08-06 15:07 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E4F85D.2010001@redhat.com \
--to=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.