All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>,
	 OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb
Date: Fri, 08 Aug 2014 14:33:57 -0700	[thread overview]
Message-ID: <53E54245.4070704@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1408081529290.23581@localhost>

On 08/08/2014 12:31 PM, Robert P. J. Day wrote:
>
> Given that there are no machine-specific files for the tslib recipe
> anymore, might as well remove this line.
>

Robert,

Can you please review the commit guidelines

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

The summary line should be in the form of
tslib: Remove ...

I know it's a trivial patch, but it would good to have the commit 
message correct.

Thanks
Sau!

> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
>    still not totally sure i know what i'm doing here, but git history
> shows that any machine-specific tslib files vanished long ago, so
> there's little reason to hang onto this. i'm willing to be corrected.
>
> diff --git a/meta/recipes-graphics/tslib/tslib_1.1.bb b/meta/recipes-graphics/tslib/tslib_1.1.bb
> index 05d58b6..6d8c7dd 100644
> --- a/meta/recipes-graphics/tslib/tslib_1.1.bb
> +++ b/meta/recipes-graphics/tslib/tslib_1.1.bb
> @@ -32,8 +32,6 @@ do_install_append() {
>   	install -m 0755 ${WORKDIR}/tslib.sh ${D}${sysconfdir}/profile.d/
>   }
>
> -SRC_URI_OVERRIDES_PACKAGE_ARCH = "0"
> -
>   # People should consider using udev's /dev/input/touchscreen0 symlink
>   # instead of detect-stylus
>   #RDEPENDS_tslib-conf_weird-machine = "detect-stylus"
>


  reply	other threads:[~2014-08-08 21:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 19:31 [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb Robert P. J. Day
2014-08-08 21:33 ` Saul Wold [this message]
2014-08-09  4:37   ` Robert P. J. Day
2014-08-09 13:17   ` Robert P. J. Day
2014-08-10 11:17     ` Paul Eggleton
2014-08-10 12:07       ` Robert P. J. Day
2015-08-29 15:45     ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E54245.4070704@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.