From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrei LUTAS <vlutas@bitdefender.com>
Subject: Re: [PATCH RFC V5 4/5] xen,
 libxc: Request page fault injection via libxc
Date: Sat, 09 Aug 2014 00:45:34 +0300
Message-ID: <53E544FE.5030503@bitdefender.com>
References: <1407340738-3374-1-git-send-email-rcojocaru@bitdefender.com>	<1407340738-3374-4-git-send-email-rcojocaru@bitdefender.com>
	<53E4FF56020000780002AA71@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53E4FF56020000780002AA71@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, xen-devel@lists.xen.org, jun.nakajima@intel.com, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 8/8/2014 5:48 PM, Jan Beulich wrote:
> Do you really mean to compare the full CR3 value here, rather than
> just bits 12...51? In which case the address_space field likely would
> better be a GPFN.
Hello,

That is a good point, with the additional observation that only bits
31..5 should be tested when in PAE mode and of course, 31..12 when
PAE and LM are both disabled.

Best regards,
Andrei.