From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Date: Sat, 09 Aug 2014 17:47:16 +0000 Subject: Re: [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issu Message-Id: <53E65EA4.6080106@xs4all.nl> List-Id: References: <1407604952-15492-1-git-send-email-suman@inforcecomputing.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guennadi Liakhovetski , Suman Kumar Cc: m.chehab@samsung.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 08/09/2014 07:36 PM, Guennadi Liakhovetski wrote: > Hi Suman, > > On Sat, 9 Aug 2014, Suman Kumar wrote: > >> Fixes a coding style issue reported by checkpatch.pl > > Thanks for your patch. To my taste checkpatch.pl has unfortunately become > too noisy with meaningless / unimportant warnings like this one. Is this > in CodingStyle? If not, my intention is to drop this. I don't see it being mentioned explicitly in the CodingStyle, but the coding style follows K&R, and they put an empty line between local variables and the start of the code. And I like it that way as well, it makes it easier to review. If you don't want to be bothered by such patches, just delegate them to me in patchwork, I don't mind. Regards, Hans > However, Mauro may > override by either taking this himself or asking me to apply this. > > Thanks > Guennadi > >> >> Signed-off-by: Suman Kumar >> --- >> drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c >> index ceaddfb..fe15a80 100644 >> --- a/drivers/media/platform/soc_camera/soc_camera_platform.c >> +++ b/drivers/media/platform/soc_camera/soc_camera_platform.c >> @@ -27,12 +27,14 @@ struct soc_camera_platform_priv { >> static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev) >> { >> struct v4l2_subdev *subdev = platform_get_drvdata(pdev); >> + >> return container_of(subdev, struct soc_camera_platform_priv, subdev); >> } >> >> static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable) >> { >> struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd); >> + >> return p->set_capture(p, enable); >> } >> >> -- >> 1.8.2 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-vbr2.xs4all.nl ([194.109.24.22]:2899 "EHLO smtp-vbr2.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751871AbaHIRro (ORCPT ); Sat, 9 Aug 2014 13:47:44 -0400 Message-ID: <53E65EA4.6080106@xs4all.nl> Date: Sat, 09 Aug 2014 19:47:16 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Guennadi Liakhovetski , Suman Kumar CC: m.chehab@samsung.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue References: <1407604952-15492-1-git-send-email-suman@inforcecomputing.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/09/2014 07:36 PM, Guennadi Liakhovetski wrote: > Hi Suman, > > On Sat, 9 Aug 2014, Suman Kumar wrote: > >> Fixes a coding style issue reported by checkpatch.pl > > Thanks for your patch. To my taste checkpatch.pl has unfortunately become > too noisy with meaningless / unimportant warnings like this one. Is this > in CodingStyle? If not, my intention is to drop this. I don't see it being mentioned explicitly in the CodingStyle, but the coding style follows K&R, and they put an empty line between local variables and the start of the code. And I like it that way as well, it makes it easier to review. If you don't want to be bothered by such patches, just delegate them to me in patchwork, I don't mind. Regards, Hans > However, Mauro may > override by either taking this himself or asking me to apply this. > > Thanks > Guennadi > >> >> Signed-off-by: Suman Kumar >> --- >> drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c >> index ceaddfb..fe15a80 100644 >> --- a/drivers/media/platform/soc_camera/soc_camera_platform.c >> +++ b/drivers/media/platform/soc_camera/soc_camera_platform.c >> @@ -27,12 +27,14 @@ struct soc_camera_platform_priv { >> static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev) >> { >> struct v4l2_subdev *subdev = platform_get_drvdata(pdev); >> + >> return container_of(subdev, struct soc_camera_platform_priv, subdev); >> } >> >> static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable) >> { >> struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd); >> + >> return p->set_capture(p, enable); >> } >> >> -- >> 1.8.2 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >