diff for duplicates of <53E83FBF.2040607@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index a1f9f40..949d93d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,7 +19,7 @@ I wanted to avoid zero mentioned in the case statement, but can add a comment explaining it. >> + case OP_ZERO: ->> + if((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) { +>> + if((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) { > > You either shouldn't mask at all here, or the mask is wrong (the primary > op is the top six bits, not the top eight). diff --git a/a/content_digest b/N1/content_digest index f7eff87..5b44d7c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,14 +2,13 @@ "ref\020140803155108.GA19710@gate.crashing.org\0" "From\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>\0" "Subject\0Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Mon, 11 Aug 2014 04:11:59 +0000\0" + "Date\0Mon, 11 Aug 2014 09:29:59 +0530\0" "To\0Segher Boessenkool <segher@kernel.crashing.org>\0" - "Cc\0agraf@suse.de" - benh@kernel.crashing.org - paulus@samba.org - linuxppc-dev@lists.ozlabs.org + "Cc\0kvm@vger.kernel.org" + agraf@suse.de kvm-ppc@vger.kernel.org - " kvm@vger.kernel.org\0" + paulus@samba.org + " linuxppc-dev@lists.ozlabs.org\0" "\00:1\0" "b\0" "On Sunday 03 August 2014 09:21 PM, Segher Boessenkool wrote:\n" @@ -33,7 +32,7 @@ "comment explaining it.\n" "\n" ">> +\tcase OP_ZERO:\n" - ">> +\t\tif((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) {\n" + ">> +\t\tif((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) {\n" "> \n" "> You either shouldn't mask at all here, or the mask is wrong (the primary\n" "> op is the top six bits, not the top eight).\n" @@ -48,4 +47,4 @@ "> Segher\n" > -c10dc21e2a0a7aac4ace09bcad9c9d0837c5a65d1c1d4be865766cd40432b530 +024013ce300244c36feface4e215fb983567c6a0f2990d40823180408b2bff44
diff --git a/a/1.txt b/N2/1.txt index a1f9f40..949d93d 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -19,7 +19,7 @@ I wanted to avoid zero mentioned in the case statement, but can add a comment explaining it. >> + case OP_ZERO: ->> + if((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) { +>> + if((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) { > > You either shouldn't mask at all here, or the mask is wrong (the primary > op is the top six bits, not the top eight). diff --git a/a/content_digest b/N2/content_digest index f7eff87..25f9928 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\020140803155108.GA19710@gate.crashing.org\0" "From\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>\0" "Subject\0Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Mon, 11 Aug 2014 04:11:59 +0000\0" + "Date\0Mon, 11 Aug 2014 09:29:59 +0530\0" "To\0Segher Boessenkool <segher@kernel.crashing.org>\0" "Cc\0agraf@suse.de" benh@kernel.crashing.org @@ -33,7 +33,7 @@ "comment explaining it.\n" "\n" ">> +\tcase OP_ZERO:\n" - ">> +\t\tif((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) {\n" + ">> +\t\tif((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) {\n" "> \n" "> You either shouldn't mask at all here, or the mask is wrong (the primary\n" "> op is the top six bits, not the top eight).\n" @@ -48,4 +48,4 @@ "> Segher\n" > -c10dc21e2a0a7aac4ace09bcad9c9d0837c5a65d1c1d4be865766cd40432b530 +82011cd8bb4475260b982a2ffb6b34c0aae9b0db59a858afd0480e2e79ff6afd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.