From: "Andreas Färber" <afaerber@suse.de>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, l@dorileo.org
Subject: Re: [Qemu-devel] [PATCH v3 4/9] qemu-log: Avoid function call for disabled qemu_log_mask logging
Date: Mon, 11 Aug 2014 12:14:44 +0100 [thread overview]
Message-ID: <53E8A5A4.8000308@suse.de> (raw)
In-Reply-To: <1406811992-6766-5-git-send-email-alex.bennee@linaro.org>
Am 31.07.2014 14:06, schrieb Alex Bennée:
> From: Peter Maydell <peter.maydell@linaro.org>
>
> Make qemu_log_mask() a macro which only calls the function to
> do the actual work if the logging is enabled. This avoids making
> a function call in possible fast paths where logging is disabled.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Lacking your Sob as submitter. If you fix that,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-08-11 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 13:06 [Qemu-devel] [PATCH v3 0/9] qemu-log dfilter and perf.map changes Alex Bennée
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 1/9] tcg: add ability to dump /tmp/perf-<pid>.map files Alex Bennée
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 2/9] tcg: light re-factor and pass down TranslationBlock Alex Bennée
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 3/9] qemu-log: correct help text for -d cpu Alex Bennée
2014-08-11 11:12 ` Andreas Färber
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 4/9] qemu-log: Avoid function call for disabled qemu_log_mask logging Alex Bennée
2014-08-11 11:14 ` Andreas Färber [this message]
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 5/9] qemu-log: Improve the "exec" TB execution logging Alex Bennée
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 6/9] qemu-log: support simple pid substitution in logfile Alex Bennée
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 7/9] qemu-log: new option -dfilter to limit output Alex Bennée
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 8/9] qemu-log: dfilter-ise exec, out_asm, and op_opt Alex Bennée
2014-07-31 13:06 ` [Qemu-devel] [PATCH v3 9/9] target-arm: dfilter support for in_asm, op, opt_op Alex Bennée
2014-08-11 9:37 ` [Qemu-devel] [PATCH v3 0/9] qemu-log dfilter and perf.map changes Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E8A5A4.8000308@suse.de \
--to=afaerber@suse.de \
--cc=alex.bennee@linaro.org \
--cc=l@dorileo.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.