All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaud Aujon <arnaud@intelibre.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] espeak : depends on MMU
Date: Mon, 11 Aug 2014 14:32:10 +0200	[thread overview]
Message-ID: <53E8B7CA.7090805@intelibre.fr> (raw)
In-Reply-To: <87wqaf70bi.fsf@dell.be.48ers.dk>

Hi,
On 08/11/2014 01:06 PM, Peter Korsgaard wrote:
>   >> http://espeak.sourceforge.net/
>   >>
>   >> +comment "espeak needs a toolchain w/ C++, wchar, threads"
>   >> +        depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
>   >> +        depends on BR2_USE_MMU
>   >> +
>
>   > While the moving of this comment seems to be the right thing to do, I believe this will break the indentation/nesting of the suboptions of espeak.
>
> Indeed. Comments should go at the very top or bottom of the file. Care
> to send a reworked patch that leaves the comment at the top?
>

Yes sure, I will re-send shortly.
I moved the comment to match the xbmc package Config.in, so I guess 
there is maybe a few other packages to fix the same way.

      reply	other threads:[~2014-08-11 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11  7:38 [Buildroot] [PATCH 1/1] espeak : depends on MMU arnaud at intelibre.fr
2014-08-11  8:11 ` Thomas De Schampheleire
2014-08-11 11:06   ` Peter Korsgaard
2014-08-11 12:32     ` Arnaud Aujon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E8B7CA.7090805@intelibre.fr \
    --to=arnaud@intelibre.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.