From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGpN2-0001qT-Na for qemu-devel@nongnu.org; Mon, 11 Aug 2014 09:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGpMw-0006OA-Pf for qemu-devel@nongnu.org; Mon, 11 Aug 2014 09:10:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48834 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGpMw-0006O6-KB for qemu-devel@nongnu.org; Mon, 11 Aug 2014 09:10:34 -0400 Message-ID: <53E8C0C9.3080500@suse.de> Date: Mon, 11 Aug 2014 15:10:33 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1407510229-28167-1-git-send-email-eric.auger@linaro.org> <1407510229-28167-6-git-send-email-eric.auger@linaro.org> In-Reply-To: <1407510229-28167-6-git-send-email-eric.auger@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 5/7] hw/arm/boot: load_dtb becomes non static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, kim.phillips@freescale.com, a.rigo@virtualopensystems.com Cc: peter.maydell@linaro.org, patches@linaro.org, will.deacon@arm.com, stuart.yoder@freescale.com, Bharat.Bhushan@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu On 08.08.14 17:03, Eric Auger wrote: > load_dtb will be used by machvirt for dynamic instantiation of > platform devices > > Signed-off-by: Eric Auger > --- > hw/arm/boot.c | 2 +- > include/hw/arm/arm.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/boot.c b/hw/arm/boot.c > index 1241761..53b43e8 100644 > --- a/hw/arm/boot.c > +++ b/hw/arm/boot.c > @@ -312,7 +312,7 @@ static void set_kernel_args_old(const struct arm_boot_info *info) > } > } > > -static int load_dtb(hwaddr addr, const struct arm_boot_info *binfo) > +int load_dtb(hwaddr addr, const struct arm_boot_info *binfo) Please rename it arm_load_dtb then. Alex > { > void *fdt = NULL; > int size, rc; > diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h > index cbbf4ca..fe58dc0 100644 > --- a/include/hw/arm/arm.h > +++ b/include/hw/arm/arm.h > @@ -68,6 +68,7 @@ struct arm_boot_info { > hwaddr entry; > }; > void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info); > +int load_dtb(hwaddr addr, const struct arm_boot_info *binfo); > > /* Multiplication factor to convert from system clock ticks to qemu timer > ticks. */