From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGr1Q-0006gB-J6 for qemu-devel@nongnu.org; Mon, 11 Aug 2014 10:56:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGr1F-00047T-8a for qemu-devel@nongnu.org; Mon, 11 Aug 2014 10:56:28 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:41891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGr1F-000477-3r for qemu-devel@nongnu.org; Mon, 11 Aug 2014 10:56:17 -0400 Received: by mail-pa0-f52.google.com with SMTP id bj1so11096074pad.25 for ; Mon, 11 Aug 2014 07:56:16 -0700 (PDT) Message-ID: <53E8D987.1000303@ozlabs.ru> Date: Tue, 12 Aug 2014 00:56:07 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1406799254-25223-1-git-send-email-aik@ozlabs.ru> <1406799254-25223-4-git-send-email-aik@ozlabs.ru> <53E8AB7A.70203@suse.de> In-Reply-To: <53E8AB7A.70203@suse.de> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 03/10] spapr_pci: Make find_phb()/find_dev() public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: Alex Williamson , qemu-ppc@nongnu.org On 08/11/2014 09:39 PM, Alexander Graf wrote: > > On 31.07.14 11:34, Alexey Kardashevskiy wrote: >> This makes find_phb()/find_dev() public and changed its names >> to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to >> be used from other parts of QEMU such as VFIO DDW (dynamic DMA window) >> or VFIO PCI error injection or VFIO EEH handling - in all these >> cases there are RTAS calls which are addressed to BUID+config_addr >> in IEEE1275 format. >> >> Signed-off-by: Alexey Kardashevskiy > > Is there any particular reason these RTAS calls can't get handled inside of > spapr_pci.c? After all, if they work on PCI granularity, they are > semantically bound to the PCI PHB emulation. Creation - yes, addressed to PHB BUID. Deletion - no, addressed to LIOBN which has nothing to do with PCI. -- Alexey