From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Kees Cook <keescook@chromium.org>, Will Drewry <wad@chromium.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Denys Vlasenko <vda.linux@googlemail.com>,
X86 ML <x86@kernel.org>, Alexei Starovoitov <ast@plumgrid.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] x86: entry_64.S: always allocate complete "struct pt_regs"
Date: Mon, 11 Aug 2014 08:13:17 -0700 [thread overview]
Message-ID: <53E8DD8D.3060500@zytor.com> (raw)
In-Reply-To: <53E8F87B020000780002B41D@mail.emea.novell.com>
On 08/11/2014 08:08 AM, Jan Beulich wrote:
>>
>> No, in *human language*. What does the DW_CFA_def_cfa_expression
>> actually aim to accomplish? If you don't know the innards of the DWARF
>> spec, the whole thing might as well be Hungarian.
>
> Just like the other DW_CFA_def_cfa_* ones it sets the current
> frame address (CFA), just not via one of the pre-canned shortcuts,
> but via an expression (in the case here de-referencing the stack
> pointer to read the top of stack, and then adding the necessary
> offset). So it indeed is similar enough to other .cfi_* annotations we
> use without further comments.
>
Actually, what you had inside the parenteses there is actually a
half-decent comment. I'm going to pretend the rest of this wasn't posted.
-hpa
next prev parent reply other threads:[~2014-08-11 15:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 14:48 [PATCH 1/5] x86: entry_64.S: delete unused code Denys Vlasenko
2014-08-01 14:48 ` [PATCH 2/5] x86: open-code register save/restore in trace_hardirqs thunks Denys Vlasenko
2014-08-01 14:48 ` [PATCH 3/5] x86: entry_64.S: fold SAVE_ARGS_IRQ macro into its sole user Denys Vlasenko
2014-08-01 18:30 ` Frederic Weisbecker
2014-08-01 14:48 ` [PATCH 4/5] x86: entry_64.S: always allocate complete "struct pt_regs" Denys Vlasenko
2014-08-01 17:04 ` Andy Lutomirski
2014-08-04 14:28 ` Denys Vlasenko
2014-08-04 14:47 ` Oleg Nesterov
2014-08-04 15:34 ` Oleg Nesterov
2014-08-04 21:03 ` Andy Lutomirski
2014-08-04 21:23 ` Borislav Petkov
2014-08-05 10:35 ` Denys Vlasenko
2014-08-05 14:53 ` Andy Lutomirski
2014-08-05 15:17 ` Denys Vlasenko
2014-08-05 23:02 ` Andy Lutomirski
2014-08-07 9:54 ` Denys Vlasenko
2014-08-01 18:09 ` Alexei Starovoitov
2014-08-01 18:30 ` Oleg Nesterov
2014-08-01 18:35 ` H. Peter Anvin
2014-08-01 22:11 ` Denys Vlasenko
2014-08-01 22:13 ` H. Peter Anvin
2014-08-02 21:14 ` Andy Lutomirski
2014-08-02 21:23 ` H. Peter Anvin
2014-08-02 21:38 ` Andy Lutomirski
2014-08-01 22:52 ` Frederic Weisbecker
2014-08-01 23:19 ` Frederic Weisbecker
2014-08-04 3:03 ` Denys Vlasenko
2014-08-04 7:57 ` Borislav Petkov
2014-08-11 0:46 ` Frederic Weisbecker
2014-08-11 8:40 ` Jan Beulich
2014-08-11 9:07 ` Andy Lutomirski
2014-08-11 9:31 ` Jan Beulich
2014-08-11 13:26 ` Denys Vlasenko
2014-08-11 14:17 ` Jan Beulich
2014-08-11 14:53 ` H. Peter Anvin
2014-08-11 15:08 ` Jan Beulich
2014-08-11 15:13 ` H. Peter Anvin [this message]
2014-08-12 9:31 ` Denys Vlasenko
2014-08-12 9:50 ` Jan Beulich
2014-08-01 14:48 ` [PATCH 5/5] x86: mass removal of ARGOFFSET Denys Vlasenko
2014-08-01 18:00 ` [PATCH 1/5] x86: entry_64.S: delete unused code Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E8DD8D.3060500@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=ast@plumgrid.com \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=vda.linux@googlemail.com \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.