From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH] scsi: Fix qemu boot hang problem Date: Mon, 11 Aug 2014 09:21:49 -0700 Message-ID: <53E8ED9D.7030809@roeck-us.net> References: <1407675265-29192-1-git-send-email-linux@roeck-us.net> <53E8CF41.2050300@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Venkatesh Srinivas , Jens Axboe Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Webb Scales List-Id: linux-scsi@vger.kernel.org On 08/11/2014 08:33 AM, Venkatesh Srinivas wrote: > Should we wrap the sdev->device_busy read and test in a new > scsi_device_busy(), so as to preserve the old polarity? > I don't see a difference in polarity, or at least replacing '== 0' with '!' is not a reverse in polarity for me. Anyway, I don't really care if or how this is wrapped, as long as it is getting fixed. Thanks, Guenter