From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XGtCs-0002Qz-6P
	for qemu-devel@nongnu.org; Mon, 11 Aug 2014 13:16:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XGtCl-0006Q2-VY
	for qemu-devel@nongnu.org; Mon, 11 Aug 2014 13:16:26 -0400
Message-ID: <53E8FA62.5050605@suse.de>
Date: Mon, 11 Aug 2014 19:16:18 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1406799254-25223-1-git-send-email-aik@ozlabs.ru>
	<1406799254-25223-4-git-send-email-aik@ozlabs.ru>
	<53E8AB7A.70203@suse.de> <53E8D987.1000303@ozlabs.ru>
In-Reply-To: <53E8D987.1000303@ozlabs.ru>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 03/10] spapr_pci: Make
	find_phb()/find_dev() public
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>, qemu-ppc@nongnu.org


On 11.08.14 16:56, Alexey Kardashevskiy wrote:
> On 08/11/2014 09:39 PM, Alexander Graf wrote:
>> On 31.07.14 11:34, Alexey Kardashevskiy wrote:
>>> This makes find_phb()/find_dev() public and changed its names
>>> to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to
>>> be used from other parts of QEMU such as VFIO DDW (dynamic DMA window)
>>> or VFIO PCI error injection or VFIO EEH handling - in all these
>>> cases there are RTAS calls which are addressed to BUID+config_addr
>>> in IEEE1275 format.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> Is there any particular reason these RTAS calls can't get handled inside of
>> spapr_pci.c? After all, if they work on PCI granularity, they are
>> semantically bound to the PCI PHB emulation.
> Creation - yes, addressed to PHB BUID. Deletion - no, addressed to LIOBN
> which has nothing to do with PCI.

Well, if there's no cleaner cut I guess the way you split it right now 
into a separate file is ok.


Alex