From: Dave Hansen <dave.hansen@linux.intel.com>
To: Jeremiah Mahler <jmmahler@gmail.com>,
David Rientjes <rientjes@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning
Date: Mon, 11 Aug 2014 10:24:02 -0700 [thread overview]
Message-ID: <53E8FC32.6070905@linux.intel.com> (raw)
In-Reply-To: <1407569913-4035-1-git-send-email-jmmahler@gmail.com>
On 08/09/2014 12:38 AM, Jeremiah Mahler wrote:
> A sparse warning is generated about 'tlb_single_page_flush_ceiling'
> not being declared.
>
> arch/x86/mm/tlb.c:177:15: warning: symbol
> 'tlb_single_page_flush_ceiling' was not declared. Should it be static?
>
> Since it isn't used anywhere outside this file, fix the warning by
> making it static.
>
> Also, optimize the use of this variable by adding the __read_mostly
> directive.
Looks fine to me. It's definitely __read_mostly.
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
prev parent reply other threads:[~2014-08-11 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 7:24 [PATCH linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning Jeremiah Mahler
2014-08-08 22:03 ` David Rientjes
2014-08-09 7:38 ` [PATCH v2 " Jeremiah Mahler
2014-08-10 7:46 ` [tip:x86/urgent] x86/mm: Fix sparse ' tlb_single_page_flush_ceiling' warning and make the variable read-mostly tip-bot for Jeremiah Mahler
2014-08-11 17:24 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E8FC32.6070905@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.