From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v6 3/4] x86/mem_event: Deliver gla fault EPT violation information Date: Mon, 11 Aug 2014 13:27:17 -0400 Message-ID: <53E8FCF5.5090404@oracle.com> References: <1407768526-29112-1-git-send-email-tamas.lengyel@zentific.com> <1407768526-29112-3-git-send-email-tamas.lengyel@zentific.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1407768526-29112-3-git-send-email-tamas.lengyel@zentific.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, JBeulich@suse.com, Aravind.Gopalakrishnan@amd.com, jun.nakajima@intel.com, suravee.suthikulpanit@amd.com List-Id: xen-devel@lists.xenproject.org On 08/11/2014 10:48 AM, Tamas K Lengyel wrote: > diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c > index 1f1f6cd..fe7b782 100644 > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -1408,7 +1408,13 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla, > req->access_r = npfec.read_access; > req->access_w = npfec.write_access; > req->access_x = npfec.insn_fetch; > - > + if ( npfec.npfec_kind == npfec_kind_with_gla ) > + req->fault_with_gla = 1; > + else if ( npfec.npfec_kind == npfec_kind_in_gpt ) > + req->fault_in_gpt = 1; > + req->access_r = npfec.read_access; > + req->access_w = npfec.write_access; > + req->access_x = npfec.insn_fetch; You seem to be assigning req->access_? values twice. -boris > req->vcpu_id = v->vcpu_id; > } >