From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from terminus.zytor.com ([2001:1868:205::10] helo=mail.zytor.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XGtlf-0003zS-Rb for kexec@lists.infradead.org; Mon, 11 Aug 2014 17:52:24 +0000 Message-ID: <53E9028E.2070709@zytor.com> Date: Mon, 11 Aug 2014 10:51:10 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH 11/15] purgatory: Core purgatory functionality References: <1403814824-7587-1-git-send-email-vgoyal@redhat.com> <1403814824-7587-12-git-send-email-vgoyal@redhat.com> <20140811174017.GD12610@digium.com> In-Reply-To: <20140811174017.GD12610@digium.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Shaun Ruffell , Vivek Goyal Cc: mjg59@srcf.ucam.org, bhe@redhat.com, greg@kroah.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bp@alien8.de, ebiederm@xmission.com, akpm@linux-foundation.org, dyoung@redhat.com, chaowang@redhat.com T24gMDgvMTEvMjAxNCAxMDo0MCBBTSwgU2hhdW4gUnVmZmVsbCB3cm90ZToKPiBGWUksIGl0IGxv b2tzIGxpa2UgdGhlIGZvbGxvd2luZyBwYXRjaCAoY29tbWl0dGVkIGluCj4gOGZjNWI0ZDQxMjFj OTU0ODJiMjU4MykgYWRkcyBhIG5ldyByZXF1aXJlbWVudCB0byB1c2UgYXQgbGVhc3QgZ2NjCj4g NC40IHRvIGJ1aWxkIHRoZSBrZXJuZWw/CgpXZWxsLCB0byBidWlsZCB0aGUga2VybmVsIHdpdGgg dGhhdCBwYXJ0aWN1bGFyIG5ldyBmdW5jdGlvbmFsaXR5CmVuYWJsZWQsIHllcy4KCkhvd2V2ZXIu Li4KCj4gVGhlIGFib3ZlICItbWNtb2RlbD1sYXJnZSIgY29tcGlsZXIgZmxhZyBwcm9kdWNlcyB0 aGUgZm9sbG93aW5nIG91dHB1dCBvbiBHQ0MgNC4xLjIuCj4gCj4gICAkIG1ha2UgbW9kdWxlc19w cmVwYXJlIDsgZ2NjIC0tdmVyc2lvbgo+ICAgICBDSEsgICAgIGluY2x1ZGUvY29uZmlnL2tlcm5l bC5yZWxlYXNlCj4gICAgIENISyAgICAgaW5jbHVkZS9nZW5lcmF0ZWQvdWFwaS9saW51eC92ZXJz aW9uLmgKPiAgICAgQ0hLICAgICBpbmNsdWRlL2dlbmVyYXRlZC91dHNyZWxlYXNlLmgKPiAgICAg Q0MgICAgICBhcmNoL3g4Ni9wdXJnYXRvcnkvcHVyZ2F0b3J5Lm8KPiAgIGFyY2gveDg2L3B1cmdh dG9yeS9wdXJnYXRvcnkuYzoxOiBzb3JyeSwgdW5pbXBsZW1lbnRlZDogY29kZSBtb2RlbCDigJhs YXJnZeKAmSBub3Qgc3VwcG9ydGVkIHlldAo+ICAgbWFrZVsxXTogKioqIFthcmNoL3g4Ni9wdXJn YXRvcnkvcHVyZ2F0b3J5Lm9dIEVycm9yIDEKPiAgIG1ha2U6ICoqKiBbYXJjaHByZXBhcmVdIEVy cm9yIDIKPiAgIGdjYyAoR0NDKSA0LjEuMiAyMDA4MDcwNCAoUmVkIEhhdCA0LjEuMi01NCkKPiAg IENvcHlyaWdodCAoQykgMjAwNiBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KPiAgIFRo aXMgaXMgZnJlZSBzb2Z0d2FyZTsgc2VlIHRoZSBzb3VyY2UgZm9yIGNvcHlpbmcgY29uZGl0aW9u cy4gIFRoZXJlIGlzIE5PCj4gICB3YXJyYW50eTsgbm90IGV2ZW4gZm9yIE1FUkNIQU5UQUJJTElU WSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4KPiAKPiBJIGRpZCBhIHF1aWNr IHNlYXJjaCBmb3IgYSBkaXNjdXNzaW9uIHRoZSBpbmRpY2F0ZXMgdGhpcyBjb21waWxlciBpcyBu b3cKPiBvZmZpY2lhbGx5IHRvbyBvbGQgdG8gYnVpbGQgdGhlIGtlcm5lbCBidXQgZGlkIG5vdCBm aW5kIG9uZS4KPiAKPiBJZiB0aGlzIGlzIHJlcXVpcmVkLCBtYXliZSBEb2N1bWVudGF0aW9uL0No YW5nZXMgbmVlZHMgdG8gYmUgdXBkYXRlZAo+IHdpdGggdGhlIG5ldyBtaW5pbXVtIHJlcXVpcmVk IHZlcnNpb24/CgouLi4gSSdtIGhhdmluZyBhIHZlcnksIHZlcnkgaGFyZCB0aW1lIHRvIHBpY3R1 cmUgYSByZWFzb24gd2h5IHRoZQoibGFyZ2UiIG1vZGVsIHdvdWxkIGJlIG5lY2Vzc2FyeSBvciBl dmVuIGRlc2lyYWJsZSBmb3IgdGhlIHB1cmdhdG9yeQpjb2RlLiAgVGhlICJzbWFsbCBQSUMiIG1v ZGVsIHNlZW0gdG8gZml0IG11Y2ggYmV0dGVyLi4uCgoJLWhwYQoKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbaHKRw3 (ORCPT ); Mon, 11 Aug 2014 13:52:29 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54656 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753857AbaHKRw2 (ORCPT ); Mon, 11 Aug 2014 13:52:28 -0400 Message-ID: <53E9028E.2070709@zytor.com> Date: Mon, 11 Aug 2014 10:51:10 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Shaun Ruffell , Vivek Goyal CC: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, mjg59@srcf.ucam.org, greg@kroah.com, bp@alien8.de, dyoung@redhat.com, chaowang@redhat.com, bhe@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH 11/15] purgatory: Core purgatory functionality References: <1403814824-7587-1-git-send-email-vgoyal@redhat.com> <1403814824-7587-12-git-send-email-vgoyal@redhat.com> <20140811174017.GD12610@digium.com> In-Reply-To: <20140811174017.GD12610@digium.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2014 10:40 AM, Shaun Ruffell wrote: > FYI, it looks like the following patch (committed in > 8fc5b4d4121c95482b2583) adds a new requirement to use at least gcc > 4.4 to build the kernel? Well, to build the kernel with that particular new functionality enabled, yes. However... > The above "-mcmodel=large" compiler flag produces the following output on GCC 4.1.2. > > $ make modules_prepare ; gcc --version > CHK include/config/kernel.release > CHK include/generated/uapi/linux/version.h > CHK include/generated/utsrelease.h > CC arch/x86/purgatory/purgatory.o > arch/x86/purgatory/purgatory.c:1: sorry, unimplemented: code model ‘large’ not supported yet > make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1 > make: *** [archprepare] Error 2 > gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-54) > Copyright (C) 2006 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > I did a quick search for a discussion the indicates this compiler is now > officially too old to build the kernel but did not find one. > > If this is required, maybe Documentation/Changes needs to be updated > with the new minimum required version? ... I'm having a very, very hard time to picture a reason why the "large" model would be necessary or even desirable for the purgatory code. The "small PIC" model seem to fit much better... -hpa