Re: [PATCH] pci: bugfix, pci_get_domain_bus_and_slot() needs to inc reference count

[Yijing Wang <wangyijing@huawei.com>]

On 2014/8/12 8:31, Liu Ping Fan wrote:
> As the notes of this function, pci_get_domain_bus_and_slot() should
> increase the reference count.

It had did it.
please refer to:

#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)

> 
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> ---
>  drivers/pci/search.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/search.c b/drivers/pci/search.c
> index 827ad83..41a5738 100644
> --- a/drivers/pci/search.c
> +++ b/drivers/pci/search.c
> @@ -258,8 +258,10 @@ struct pci_dev *pci_get_domain_bus_and_slot(int domain, unsigned int bus,
>  
>  	for_each_pci_dev(dev) {
>  		if (pci_domain_nr(dev->bus) == domain &&
> -		    (dev->bus->number == bus && dev->devfn == devfn))
> +		    (dev->bus->number == bus && dev->devfn == devfn)) {
> +			pci_dev_get(dev);
>  			return dev;
> +		}
>  	}
>  	return NULL;
>  }
> 


-- 
Thanks!
Yijing