From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: fix ERASE_GRP_DEF handling
Date: Tue, 12 Aug 2014 13:24:32 +0900 [thread overview]
Message-ID: <53E99700.3030801@samsung.com> (raw)
In-Reply-To: <OF1DCACC94.2F2894EE-ONC1257D2E.002ACA34-C1257D2E.002ACA36@br-automation.com>
Hi, Hannes.
On 08/08/2014 04:47 PM, Hannes Petermaier wrote:
> if we set manually this bit on the eMMC card using mmc_switch(...),
> we also have to set it within our (before read) internal structure
> 'ext_csd'.
>
> Otherwise following checks on this will fail.
>
> Signed-off-by: Hannes Petermaier <oe5hpm@oevsv.at>
> ---
> drivers/mmc/mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index a26f3ce..52a8e36 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1010,6 +1010,8 @@ static int mmc_startup(struct mmc *mmc)
>
> if (err)
> return err;
> + else
> + ext_csd[EXT_CSD_ERASE_GROUP_DEF] = 1;
When is this value read?
If i'm right, you means that it has to set before comparing with test_csd, right?
It's reasonable, but i'm not sure that hard-coding is right.
Best Regards,
Jaehoon Chung
>
> /* Read out group size from ext_csd */
> mmc->erase_grp_size =
>
next prev parent reply other threads:[~2014-08-12 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 7:47 [U-Boot] [PATCH] mmc: fix ERASE_GRP_DEF handling Hannes Petermaier
2014-08-12 4:24 ` Jaehoon Chung [this message]
2014-08-12 5:47 ` Hannes Petermaier
2014-10-02 10:49 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E99700.3030801@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.