From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Benjamin Lee <leeben@linux.vnet.ibm.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dany@us.ibm.com, dany4madden@gmail.com,
benjamin.fik.lee@gmail.com
Subject: Re: [PATCH] Made bpf_internal_load_pointer_neg_helper static: fixes Sparse warning
Date: Tue, 12 Aug 2014 07:21:20 +0200 [thread overview]
Message-ID: <53E9A450.7070608@redhat.com> (raw)
In-Reply-To: <CAADnVQKbYheiRF_fmUnUUfSQgxUupY5vrjcjwimwwy-gnGhz2w@mail.gmail.com>
On 08/12/2014 02:57 AM, Alexei Starovoitov wrote:
> On Mon, Aug 11, 2014 at 3:00 PM, Benjamin Lee <leeben@linux.vnet.ibm.com> wrote:
>> I wanted to know what the current status of my patch is since my
>> internship will be ending this Friday and I want to know before then. if
>> there are any problems with it I can fix them before Thursday. Thank you
>> in advance.
>
> using scripts/get_maintainer.pl for cc list would have helped to
> receive response sooner.
>
>> On Fri, 2014-07-18 at 11:34 -0700, Benjamin Lee wrote:
>>> This patch fixes the following Sparse warning:
>>>
>>> net/core/filter.c:52:6: warning: symbol
>>> 'bpf_internal_load_pointer_neg_helper' was not declared. Should it be
>>> static?
>>>
>>> I declared bpf_internal_load_pointer_neg_helper as static because it
>>> is not referenced elsewhere in the kernel. The patched kernel boots
>
> the patch is incorrect, since this function is called out of assembler.
> Try 'git grep bpf_internal_load_pointer_neg_helper'
Agreed.
prev parent reply other threads:[~2014-08-12 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405708449.11800.2.camel@oc1318858833.ibm.com>
2014-08-11 22:00 ` [PATCH] Made bpf_internal_load_pointer_neg_helper static: fixes Sparse warning Benjamin Lee
2014-08-12 0:57 ` Alexei Starovoitov
2014-08-12 5:21 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E9A450.7070608@redhat.com \
--to=dborkman@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=benjamin.fik.lee@gmail.com \
--cc=dany4madden@gmail.com \
--cc=dany@us.ibm.com \
--cc=davem@davemloft.net \
--cc=leeben@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.