Re: [PATCH 1/4] VMX: fix DebugCtl MSR clearing

[Andrew Cooper <andrew.cooper3@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1310 bytes --]

On 12/08/14 10:14, Jan Beulich wrote:
> The previous shortcut was wrong, as it bypassed the necessary vmwrite:
> All we really want to avoid if the guest writes zero is to add the MSR
> to the host-load list.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -2246,8 +2246,6 @@ static int vmx_msr_write_intercept(unsig
>          int i, rc = 0;
>          uint64_t supported = IA32_DEBUGCTLMSR_LBR | IA32_DEBUGCTLMSR_BTF;
>  
> -        if ( !msr_content )
> -            break;
>          if ( msr_content & ~supported )
>          {
>              /* Perhaps some other bits are supported in vpmu. */
> @@ -2267,12 +2265,10 @@ static int vmx_msr_write_intercept(unsig
>          }
>  
>          if ( (rc < 0) ||
> -             (vmx_add_host_load_msr(msr) < 0) )
> +             (msr_content && (vmx_add_host_load_msr(msr) < 0)) )
>              hvm_inject_hw_exception(TRAP_machine_check, 0);
>          else
> -        {
>              __vmwrite(GUEST_IA32_DEBUGCTL, msr_content);
> -        }
>  
>          break;
>      }
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel


[-- Attachment #1.2: Type: text/html, Size: 2193 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel