From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Ungerer Subject: Re: [PATCH 0/3] fs/proc/task_nommu.c: copy-and-paste the changes from task_mmu.c Date: Tue, 12 Aug 2014 23:57:31 +1000 Message-ID: <53EA1D4B.5030401@uclinux.org> References: <20140805194627.GA30693@redhat.com> <20140811170008.GA24629@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Viro , Cyrill Gorcunov , David Howells , "David S. Miller" , "Eric W. Biederman" , "Kirill A. Shutemov" , "Kirill A. Shutemov" , Peter Zijlstra , Sasha Levin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Oleg Nesterov , Andrew Morton Return-path: Received: from icp-osb-irony-out1.external.iinet.net.au ([203.59.1.210]:54921 "EHLO icp-osb-irony-out1.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbaHLOJT (ORCPT ); Tue, 12 Aug 2014 10:09:19 -0400 In-Reply-To: <20140811170008.GA24629@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Oleg, On 12/08/14 03:00, Oleg Nesterov wrote: > Greg, could you review? The changes are simple, but I am not familiar > with NOMMU and I can't test this. > > Depends on > > [PATCH v2 3/7] proc: introduce proc_mem_open() > http://marc.info/?l=linux-kernel&m=140726831328943 > > [PATCH v2 4/7] fs/proc/task_mmu.c: shift mm_access() from m_start() to proc_maps_open() > http://marc.info/?l=linux-kernel&m=140726828328929 > (only because it adds proc_maps_private->mm) > > I'll also send you mbox with the previous series just in case. > > Oleg. > > fs/proc/task_nommu.c | 65 ++++++++++++++++++++++++++++++-------------------- > 1 files changed, 39 insertions(+), 26 deletions(-) I don't see any problems. Applied cleanly for me (to a 3.16-rc7 tree), compiled cleanly for a non-mmu m68k target, and ran with no problems I could see. At least I checked /proc/1/maps and that still came out fine. Is there anything else I should check? I am happy to ack it: Acked-by: Greg Ungerer Regards Greg