From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity Date: Tue, 12 Aug 2014 10:41:08 -0600 Message-ID: <53EA43A4.2070301@wwwdotorg.org> References: <20140811180307.GA25677@core.coreip.homeip.net> <53EA431F.6020908@itdev.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:37085 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752685AbaHLQkz (ORCPT ); Tue, 12 Aug 2014 12:40:55 -0400 In-Reply-To: <53EA431F.6020908@itdev.co.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Nick Dyer Cc: Dmitry Torokhov , linux-input@vger.kernel.org, Yufeng Shen , Benson Leung , Stephen Warren , linux-kernel@vger.kernel.org On 08/12/2014 10:38 AM, Nick Dyer wrote: > On 11/08/14 19:03, Dmitry Torokhov wrote: >> This should fix the following issues reported by Coverity: >> >> *** CID 1230625: Logically dead code (DEADCODE) >> /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() >> >> *** CID 1230627: Missing break in switch (MISSING_BREAK) >> /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_object_table() >> >> *** CID 1230629: Out-of-bounds write (OVERRUN) >> /drivers/input/touchscreen/atmel_mxt_ts.c: 1267 in mxt_update_cfg() >> >> *** CID 1230632: Unused pointer value (UNUSED_VALUE) >> /drivers/input/touchscreen/atmel_mxt_ts.c: 1211 in mxt_update_cfg() >> >> Signed-off-by: Dmitry Torokhov > > I've reviewed these changes and they look correct to me. Apologies that > they slipped through, most of it is bad merging on my part I think. > > Signed-off-by: Nick Dyer Don't you mean Acked-by or Reviewed-by?