All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: "linux kernel mailing list" <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Daniel Walter" <sahne@0x90.at>,
	"Toralf Förster" <toralf.foerster@gmx.de>,
	user-mode-linux-devel
	<user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH] resource: Fix the case of null pointer access
Date: Tue, 12 Aug 2014 19:38:06 +0200	[thread overview]
Message-ID: <53EA50FE.8060103@nod.at> (raw)
In-Reply-To: <20140812150417.GC16961@redhat.com>

Am 12.08.2014 17:04, schrieb Vivek Goyal:
> On Tue, Aug 12, 2014 at 04:49:35PM +0200, Richard Weinberger wrote:
>> Am 12.08.2014 16:46, schrieb Vivek Goyal:
>>> Richard and Daniel reported that UML is broken due to changes to resource
>>> traversal functions. Problem is that iomem_resource.child can be null
>>> and new code does not consider that possibility. Old code used a for loop
>>> and that loop will not even execute if p was null.
>>>
>>> Revert back to for() loop logic and bail out if p is null.
>>>
>>> I also moved sibling_only check out of resource_lock. There is no
>>> reason to keep it inside the lock.
>>>
>>> Following is backtrace of the UML crash.
>>
>> Shall I pickup this patch and route it via my uml tree to Linus?
> 
> I am fine with that. 

Whoops, I oversaw that your patch does not touch anything in arch/um/.
It is not UML specific. Let's see what Andrew says.

Thanks,
//richard

      reply	other threads:[~2014-08-12 17:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 14:46 [uml-devel] [PATCH] resource: Fix the case of null pointer access Vivek Goyal
2014-08-12 14:46 ` Vivek Goyal
2014-08-12 14:49 ` Richard Weinberger
2014-08-12 15:04   ` Vivek Goyal
2014-08-12 17:38     ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EA50FE.8060103@nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sahne@0x90.at \
    --cc=toralf.foerster@gmx.de \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.