From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v2 1/3] ARM: EXYNOS: Fix build with PM_SLEEP=n and ARM_EXYNOS_CPUIDLE=n Date: Tue, 12 Aug 2014 22:49:12 +0200 Message-ID: <53EA7DC8.6040801@linaro.org> References: <1407856317-2457-1-git-send-email-b.zolnierkie@samsung.com> <1407856317-2457-2-git-send-email-b.zolnierkie@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f47.google.com ([74.125.82.47]:58345 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbaHLUtP (ORCPT ); Tue, 12 Aug 2014 16:49:15 -0400 Received: by mail-wg0-f47.google.com with SMTP id b13so10364259wgh.18 for ; Tue, 12 Aug 2014 13:49:14 -0700 (PDT) In-Reply-To: <1407856317-2457-2-git-send-email-b.zolnierkie@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Bartlomiej Zolnierkiewicz , Kukjin Kim Cc: Tomasz Figa , Marek Szyprowski , Krzysztof Kozlowski , Sachin Kamat , Kyungmin Park , Olof Johansson , Russell King , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 08/12/2014 05:11 PM, Bartlomiej Zolnierkiewicz wrote: > Fix building of exynos_defconfig with disabled CONFIG_PM_SLEEP by > adding checking whether Exynos cpuidle support is enabled before > accessing exynos_enter_aftr. > > The build error message: > arch/arm/mach-exynos/built-in.o:(.data+0x74): undefined reference to = `exynos_enter_aftr' > make: *** [vmlinux] Error 1 > > This patch has been tested on Exynos4210 based Origen board. > > Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Kyungmin Park > --- > arch/arm/mach-exynos/exynos.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exy= nos.c > index 6a24e11..d57f136 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -161,7 +161,9 @@ static void exynos_restart(enum reboot_mode mode,= const char *cmd) > > static struct platform_device exynos_cpuidle =3D { > .name =3D "exynos_cpuidle", > +#ifdef CONFIG_ARM_EXYNOS_CPUIDLE > .dev.platform_data =3D exynos_enter_aftr, > +#endif > .id =3D -1, > }; This patch does not address the real issue of the compilation error. Th= e=20 cpuidle driver needs the exynos_enter_aftr function in order to work=20 correctly. Hence the Makefile should be fixed in order to compile pm.o=20 if cpuidle or pm_sleep are set. --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 12 Aug 2014 22:49:12 +0200 Subject: [PATCH v2 1/3] ARM: EXYNOS: Fix build with PM_SLEEP=n and ARM_EXYNOS_CPUIDLE=n In-Reply-To: <1407856317-2457-2-git-send-email-b.zolnierkie@samsung.com> References: <1407856317-2457-1-git-send-email-b.zolnierkie@samsung.com> <1407856317-2457-2-git-send-email-b.zolnierkie@samsung.com> Message-ID: <53EA7DC8.6040801@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/12/2014 05:11 PM, Bartlomiej Zolnierkiewicz wrote: > Fix building of exynos_defconfig with disabled CONFIG_PM_SLEEP by > adding checking whether Exynos cpuidle support is enabled before > accessing exynos_enter_aftr. > > The build error message: > arch/arm/mach-exynos/built-in.o:(.data+0x74): undefined reference to `exynos_enter_aftr' > make: *** [vmlinux] Error 1 > > This patch has been tested on Exynos4210 based Origen board. > > Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Kyungmin Park > --- > arch/arm/mach-exynos/exynos.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index 6a24e11..d57f136 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -161,7 +161,9 @@ static void exynos_restart(enum reboot_mode mode, const char *cmd) > > static struct platform_device exynos_cpuidle = { > .name = "exynos_cpuidle", > +#ifdef CONFIG_ARM_EXYNOS_CPUIDLE > .dev.platform_data = exynos_enter_aftr, > +#endif > .id = -1, > }; This patch does not address the real issue of the compilation error. The cpuidle driver needs the exynos_enter_aftr function in order to work correctly. Hence the Makefile should be fixed in order to compile pm.o if cpuidle or pm_sleep are set. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog