* [Qemu-trivial] [PATCH] apic: Fix reported DFR content
@ 2014-08-09 14:05 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2014-08-09 14:05 UTC (permalink / raw)
To: qemu-trivial; +Cc: Paolo Bonzini, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
From: Jan Kiszka <jan.kiszka@siemens.com>
IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
Fixes Jailhouse hypervisor start with in-kernel irqchips off.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/intc/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index ef19e55..03ff9e9 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@ -698,7 +698,7 @@ static uint32_t apic_mem_readl(void *opaque, hwaddr addr)
val = s->log_dest << 24;
break;
case 0x0e:
- val = s->dest_mode << 28;
+ val = (s->dest_mode << 28) | 0xfffffff;
break;
case 0x0f:
val = s->spurious_vec;
--
1.8.1.1.298.ge7eed54
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] apic: Fix reported DFR content
@ 2014-08-09 14:05 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2014-08-09 14:05 UTC (permalink / raw)
To: qemu-trivial; +Cc: Paolo Bonzini, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
From: Jan Kiszka <jan.kiszka@siemens.com>
IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
Fixes Jailhouse hypervisor start with in-kernel irqchips off.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/intc/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index ef19e55..03ff9e9 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@ -698,7 +698,7 @@ static uint32_t apic_mem_readl(void *opaque, hwaddr addr)
val = s->log_dest << 24;
break;
case 0x0e:
- val = s->dest_mode << 28;
+ val = (s->dest_mode << 28) | 0xfffffff;
break;
case 0x0f:
val = s->spurious_vec;
--
1.8.1.1.298.ge7eed54
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] apic: Fix reported DFR content
2014-08-09 14:05 ` [Qemu-devel] " Jan Kiszka
@ 2014-08-13 6:14 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2014-08-13 6:14 UTC (permalink / raw)
To: Jan Kiszka, qemu-trivial; +Cc: Paolo Bonzini, qemu-devel
09.08.2014 18:05, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
>
> Fixes Jailhouse hypervisor start with in-kernel irqchips off.
Applied to -trivial, thank you!
Are the other similar cases in there okay?
Say, 0x0d or 0x02 which also uses shifts like this one?
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] apic: Fix reported DFR content
@ 2014-08-13 6:14 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2014-08-13 6:14 UTC (permalink / raw)
To: Jan Kiszka, qemu-trivial; +Cc: Paolo Bonzini, qemu-devel
09.08.2014 18:05, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
>
> Fixes Jailhouse hypervisor start with in-kernel irqchips off.
Applied to -trivial, thank you!
Are the other similar cases in there okay?
Say, 0x0d or 0x02 which also uses shifts like this one?
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] apic: Fix reported DFR content
2014-08-13 6:14 ` [Qemu-devel] " Michael Tokarev
@ 2014-08-13 7:09 ` Jan Kiszka
-1 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2014-08-13 7:09 UTC (permalink / raw)
To: Michael Tokarev, qemu-trivial; +Cc: Paolo Bonzini, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On 2014-08-13 08:14, Michael Tokarev wrote:
> 09.08.2014 18:05, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
>>
>> Fixes Jailhouse hypervisor start with in-kernel irqchips off.
>
> Applied to -trivial, thank you!
>
> Are the other similar cases in there okay?
> Say, 0x0d or 0x02 which also uses shifts like this one?
Nope, didn't find any.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] apic: Fix reported DFR content
@ 2014-08-13 7:09 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2014-08-13 7:09 UTC (permalink / raw)
To: Michael Tokarev, qemu-trivial; +Cc: Paolo Bonzini, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On 2014-08-13 08:14, Michael Tokarev wrote:
> 09.08.2014 18:05, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
>>
>> Fixes Jailhouse hypervisor start with in-kernel irqchips off.
>
> Applied to -trivial, thank you!
>
> Are the other similar cases in there okay?
> Say, 0x0d or 0x02 which also uses shifts like this one?
Nope, didn't find any.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-13 7:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-09 14:05 [Qemu-trivial] [PATCH] apic: Fix reported DFR content Jan Kiszka
2014-08-09 14:05 ` [Qemu-devel] " Jan Kiszka
2014-08-13 6:14 ` [Qemu-trivial] " Michael Tokarev
2014-08-13 6:14 ` [Qemu-devel] " Michael Tokarev
2014-08-13 7:09 ` Jan Kiszka
2014-08-13 7:09 ` [Qemu-devel] " Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.